r85461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85460‎ | r85461 | r85462 >
Date:19:41, 5 April 2011
Author:diederik
Status:deferred
Tags:
Comment:
Updated function name.
Modified paths:
  • /trunk/tools/editor_trends/analyses/plugins/ets_cohort_backward_bar.py (modified) (history)
  • /trunk/tools/editor_trends/analyses/plugins/ets_cohort_backward_histogram.py (modified) (history)
  • /trunk/tools/editor_trends/analyses/plugins/ets_cohort_forward_bar.py (modified) (history)
  • /trunk/tools/editor_trends/analyses/plugins/ets_cohort_forward_histogram.py (modified) (history)

Diff [purge]

Index: trunk/tools/editor_trends/analyses/plugins/ets_cohort_forward_histogram.py
@@ -21,7 +21,7 @@
2222 from dateutil.relativedelta import *
2323 import calendar
2424
25 -def cohort_dataset_forward_histogram(var, editor, **kwargs):
 25+def ets_cohort_forward_histogram(var, editor, **kwargs):
2626 '''
2727 The forward looking histogram looks for every month that an editor
2828 was part of the Wikimedia community whether this person made at least cutoff
@@ -34,7 +34,6 @@
3535 #final_edit = editor['final_edit'].year + 1
3636 #yearly_edits = editor['edits_by_year']
3737
38 -
3938 if n >= var.cum_cutoff and new_wikipedian != False:
4039 years = edits.keys()
4140 for year in years:
Index: trunk/tools/editor_trends/analyses/plugins/ets_cohort_backward_bar.py
@@ -22,7 +22,7 @@
2323 from utils import data_converter
2424
2525
26 -def cohort_dataset_backward_bar(var, editor, **kwargs):
 26+def ets_cohort_backward_bar(var, editor, **kwargs):
2727 '''
2828 The backward looking bar chart looks for every year that an editor
2929 was part of the Wikimedia community whether this person made at least cutoff
Index: trunk/tools/editor_trends/analyses/plugins/ets_cohort_forward_bar.py
@@ -18,7 +18,7 @@
1919 __version__ = '0.1'
2020
2121
22 -def cohort_dataset_forward_bar(var, editor, **kwargs):
 22+def ets_cohort_forward_bar(var, editor, **kwargs):
2323 '''
2424 The forward looking bar charts looks for every month that an editor
2525 was part of the Wikimedia community whether this person made at least cutoff
Index: trunk/tools/editor_trends/analyses/plugins/ets_cohort_backward_histogram.py
@@ -21,7 +21,7 @@
2222 from dateutil.relativedelta import relativedelta
2323 from utils import data_converter
2424
25 -def histogram_by_backward_cohort(var, editor, **kwargs):
 25+def ets_cohort_backward_histogram(var, editor, **kwargs):
2626 break_down = kwargs.pop('break_down', False)
2727 new_wikipedian = editor['new_wikipedian']
2828 edits = editor['edit_count']