r85378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85377‎ | r85378 | r85379 >
Date:21:10, 4 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Partial merge of r83017
Modified paths:
  • /branches/REL1_17/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/db/DatabaseOracle.php
@@ -793,13 +793,8 @@
794794
795795 # Returns the size of a text field, or -1 for "unlimited"
796796 function textFieldSize( $table, $field ) {
797 - $fieldInfoData = $this->fieldInfo( $table, $field);
798 - if ( $fieldInfoData->type == 'varchar' ) {
799 - $size = $row->size - 4;
800 - } else {
801 - $size = $row->size;
802 - }
803 - return $size;
 797+ $fieldInfoData = $this->fieldInfo( $table, $field );
 798+ return $fieldInfoData->maxLength();
804799 }
805800
806801 function limitResult( $sql, $limit, $offset = false ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83017* OracleInstaller now also supports installation with (requested by Tim):...freakolowsky13:50, 1 March 2011

Status & tagging log