r85379 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85378‎ | r85379 | r85380 >
Date:21:13, 4 April 2011
Author:reedy
Status:resolved
Tags:
Comment:
Fixup a few undefined variables and alike while checking REL1_17
Modified paths:
  • /trunk/phase3/includes/Feed.php (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /trunk/phase3/maintenance/checkUsernames.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/checkUsernames.php
@@ -45,7 +45,7 @@
4646 foreach ( $res as $row ) {
4747 if ( ! User::isValidUserName( $row->user_name ) ) {
4848 $this->error( sprintf( "%s: %6d: '%s'\n", wfWikiID(), $row->user_id, $row->user_name ) );
49 - wfDebugLog( 'checkUsernames', $out );
 49+ wfDebugLog( 'checkUsernames', $$row->user_name );
5050 }
5151 }
5252 }
Index: trunk/phase3/includes/ImagePage.php
@@ -535,8 +535,6 @@
536536 * @param int $height
537537 */
538538 private function makeSizeLink( $params, $width, $height ) {
539 - global $wgLang;
540 -
541539 $params['width'] = $width;
542540 $params['height'] = $height;
543541 $thumbnail = $this->displayImg->transform( $params );
Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -932,7 +932,7 @@
933933 $overhead = "SAVEPOINT $ignore ON ROLLBACK RETAIN CURSORS";
934934 db2_exec( $this->mConn, $overhead, $this->mStmtOptions );
935935
936 - $this->execute( $stmt, $row );
 936+ $res2 = $this->execute( $stmt, $row );
937937
938938 if ( !$res2 ) {
939939 $this->installPrint( 'Last error:' );
Index: trunk/phase3/includes/Feed.php
@@ -101,7 +101,7 @@
102102 */
103103 public function setUniqueId($uniqueId, $RSSisPermalink = false) {
104104 $this->UniqueId = $uniqueId;
105 - $this->RSSIsPermalink = $isPermalink;
 105+ $this->RSSIsPermalink = $RSSisPermalink;
106106 }
107107
108108 /**
Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -107,7 +107,7 @@
108108 }
109109 break;
110110 }
111 -
 111+
112112 // Check if we can make the requested thumbnail, and get transform parameters.
113113 $finalThumbParams = $this->mergeThumbParams( $img, $scale, $params['urlparam'] );
114114
@@ -119,7 +119,7 @@
120120 ( is_null( $params['end'] ) || $img->getTimestamp() >= $params['end'] )
121121 ) {
122122 $gotOne = true;
123 -
 123+
124124 $fit = $this->addPageSubItem( $pageId,
125125 self::getInfo( $img, $prop, $result, $finalThumbParams ) );
126126 if ( !$fit ) {
@@ -383,7 +383,7 @@
384384 if ( $mime ) {
385385 $vals['mime'] = $file->getMimeType();
386386 }
387 -
 387+
388388 if ( $mediatype ) {
389389 $vals['mediatype'] = $file->getMediaType();
390390 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r85380Fixup numerous undefined variables (some from r85379), possibly around in var...reedy21:14, 4 April 2011
r85387Fix $$ from r85379reedy22:34, 4 April 2011

Status & tagging log