r85257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85256‎ | r85257 | r85258 >
Date:14:34, 3 April 2011
Author:happy-melon
Status:deferred (Comments)
Tags:
Comment:
Try and fix fatals on TWN
Modified paths:
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -209,7 +209,6 @@
210210
211211 $options = $parser->getOptions();
212212
213 - $sk = $options->getSkin();
214213 if ( method_exists( $options, 'getUserLang' ) ) {
215214 $userLangCode = $options->getUserLang();
216215 } else {
@@ -246,9 +245,9 @@
247246 if ( $parser->getTitle()->getText() === $_title->getText() ) {
248247 $languages[] = Html::rawElement( 'b', null, "*$name* $percent" );
249248 } elseif ( $code === $userLangCode ) {
250 - $languages[] = $sk->linkKnown( $_title, Html::rawElement( 'b', null, "$name $percent" ) );
 249+ $languages[] = Linker::linkKnown( $_title, Html::rawElement( 'b', null, "$name $percent" ) );
251250 } else {
252 - $languages[] = $sk->linkKnown( $_title, "$name $percent" );
 251+ $languages[] = Linker::linkKnown( $_title, "$name $percent" );
253252 }
254253 }
255254

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85247Followup r85244; Define all methods as static, implement a DummyLinker to for...dantman12:04, 3 April 2011

Comments

#Comment by Krinkle (talk | contribs)   14:54, 3 April 2011

This is a follow-up

#Comment by Krinkle (talk | contribs)   14:54, 3 April 2011

to r85247.

#Comment by Happy-melon (talk | contribs)   14:58, 3 April 2011

This fixes one immediate issue, but it only gets a few lines further before choking on something else wrong in r85247.

#Comment by Happy-melon (talk | contribs)   16:23, 19 April 2011

Remind me what's to fix about this revision?

#Comment by Nikerabbit (talk | contribs)   16:25, 19 April 2011

Linker:: is not compatible with 1.16

#Comment by Happy-melon (talk | contribs)   16:31, 19 April 2011

Oh yes. AFAIK, since Daniel included backwards-compatibility, this can just be reverted.

#Comment by Happy-melon (talk | contribs)   18:51, 20 April 2011

Overwritten in r86511.

Status & tagging log