r85179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85178‎ | r85179 | r85180 >
Date:08:22, 2 April 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Followup r80398: fix overspecific css rules which broke
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
——@@ -228,7 +228,7 @@
229229 }
230230
231231 /* Special:AllPages styling */
232 -td.mw-allpages-nav, p.mw-allpages-nav, td.mw-allpages-alphaindexline {
 232+.mw-allpages-nav, td.mw-allpages-alphaindexline {
233233 text-align: left;
234234 }
235235
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.css
——@@ -23,7 +23,7 @@
2424 td.mw-allpages-alphaindexline {
2525 text-align: right;
2626 }
27 -td.mw-allpages-nav, p.mw-allpages-nav {
 27+.mw-allpages-nav {
2828 text-align: right;
2929 font-size: smaller;
3030 margin-bottom: 1em;
——@@ -266,4 +266,4 @@
267267 table.mw-userrights-groups * td,
268268 table.mw-userrights-groups * th {
269269 padding-right: 1.5em;
270 -}
\ No newline at end of file
 270+}

Sign-offs

UserFlagDate
Krinkleinspected21:54, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80398Some cleanup to this horrible piece of codenikerabbit14:45, 15 January 2011

Comments

#Comment by Krinkle (talk | contribs)   07:47, 26 May 2011

What broke exactly ?

Looks alright otherwise, marking OK.

#Comment by Nikerabbit (talk | contribs)   09:03, 26 May 2011

td changed to div or something, so the rules didn't match anymore after my some previous change.

#Comment by Krinkle (talk | contribs)   10:04, 26 May 2011

Thanks!

Status & tagging log