r85031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85030‎ | r85031 | r85032 >
Date:18:42, 30 March 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Rename DeleteBatch class to SpecialDeleteBatch
Modified paths:
  • /trunk/extensions/DeleteBatch/DeleteBatch.body.php (modified) (history)
  • /trunk/extensions/DeleteBatch/DeleteBatch.php (modified) (history)
  • /trunk/extensions/SiteMatrix/SiteMatrixApi.php (modified) (history)
  • /trunk/extensions/WikiSync/WikiSyncApi.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DeleteBatch/DeleteBatch.body.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -class DeleteBatch extends SpecialPage {
 4+class SpecialDeleteBatch extends SpecialPage {
55 /**
66 * Constructor
77 */
Index: trunk/extensions/DeleteBatch/DeleteBatch.php
@@ -30,8 +30,8 @@
3131 $dir = dirname( __FILE__ ) . '/';
3232 $wgExtensionMessagesFiles['DeleteBatch'] = $dir . 'DeleteBatch.i18n.php';
3333 $wgExtensionAliasesFiles['DeleteBatch'] = $dir . 'DeleteBatch.alias.php';
34 -$wgAutoloadClasses['DeleteBatch'] = $dir . 'DeleteBatch.body.php';
35 -$wgSpecialPages['DeleteBatch'] = 'DeleteBatch';
 34+$wgAutoloadClasses['SpecialDeleteBatch'] = $dir . 'DeleteBatch.body.php';
 35+$wgSpecialPages['SpecialDeleteBatch'] = 'DeleteBatch';
3636 // Special page group for MW 1.13+
3737 $wgSpecialPageGroups['DeleteBatch'] = 'pagetools';
3838
Index: trunk/extensions/WikiSync/WikiSyncApi.php
@@ -666,7 +666,7 @@
667667 if ( !$wgUser->matchEditToken( $params['token'] ) ) {
668668 $this->dieUsageMsg( array('sessionfailure') );
669669 }
670 - $source = null;
 670+
671671 if ( !$wgUser->isAllowed( 'importupload' ) ) {
672672 $this->dieUsageMsg( array('cantimport-upload') );
673673 }
Index: trunk/extensions/SiteMatrix/SiteMatrixApi.php
@@ -89,11 +89,11 @@
9090 }
9191
9292 protected function getAllowedParams() {
93 - return array ();
 93+ return array();
9494 }
9595
9696 protected function getParamDescription() {
97 - return array ();
 97+ return array();
9898 }
9999
100100 protected function getDescription() {
@@ -112,7 +112,7 @@
113113 }
114114
115115 protected function getExamples() {
116 - return array (
 116+ return array(
117117 'api.php?action=sitematrix',
118118 );
119119 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r88803Fix for r85031 - the wrong string was changedyaron18:02, 25 May 2011
r88867Another fix for r85031 - an instance of 'DeleteBatch' was missedyaron23:51, 25 May 2011

Comments

#Comment by Siebrand (talk | contribs)   18:53, 30 March 2011

Contains more changes than the commit summary suggests. Please review!

#Comment by Reedy (talk | contribs)   19:20, 30 March 2011

Fail!

SiteMatrix is only whitespace,

Wikisync the variable was unused

Status & tagging log