r85006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85005‎ | r85006 | r85007 >
Date:12:58, 30 March 2011
Author:happy-melon
Status:reverted (Comments)
Tags:
Comment:
Additional release notes for r85005, which I meant to commit as two separate revisions as one needs to be backported (grr...)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
——@@ -208,6 +208,9 @@
209209 * (bug 15641) blocked administrators are now prevented from deleting or protecting
210210 their own talk page; and all blocked users are more comprehensively prevented
211211 from performing other actions
 212+* (bug 15641) Fixed positioning of permissions checks in Special:Import which
 213+ allowed users without the 'import' permission to import pages if they directly
 214+ submitted the form.
212215
213216 === API changes in 1.18 ===
214217 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r85075MFT r85005 & r85006...platonides18:06, 31 March 2011
r86204Revert r85006platonides12:59, 16 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85005(bug 15641) tweak Title::checkUserBlock() so that Title::getUserPermissionsEr...happy-melon12:53, 30 March 2011

Comments

#Comment by Platonides (talk | contribs)   18:08, 31 March 2011

I don't like too much the wording. Check my vesion at r85075.

As it is backported, I think we should revert this revision, and leave it at 1.17 RELEASE-NOTES (merged into HISTORY at release).

#Comment by Happy-melon (talk | contribs)   20:49, 31 March 2011

If it sticks in 1.17, then yes, I agree.

Status & tagging log