r84844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84843‎ | r84844 | r84845 >
Date:14:13, 27 March 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix default implementation of ResourceLoaderModule::getStyles() to return an array, not a string. Was causing problems with another function that was being fed the return value of getStyles() and used an array type hint
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderModule.php
@@ -135,7 +135,7 @@
136136 */
137137 public function getStyles( ResourceLoaderContext $context ) {
138138 // Stub, override expected
139 - return '';
 139+ return array();
140140 }
141141
142142 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r848451.17wmf1: MFT r84844catrope14:14, 27 March 2011

Status & tagging log