r84840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84839‎ | r84840 | r84841 >
Date:05:58, 27 March 2011
Author:purodha
Status:ok (Comments)
Tags:
Comment:
(bug 24081, bug 28268) Add tooltip to "my new messages" in personal tool links, texts consistent with others, 0 new messages shown, too.
Modified paths:
  • /trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php
——@@ -287,8 +287,10 @@
288288 'lqt-feed-new-thread-intro' => 'New thread on $1 posted by $2',
289289 'lqt-feed-reply-intro' => 'Reply to $3 (on $1) posted by $2',
290290
291 - 'lqt-newmessages-n' => 'New messages ($1)',
292 - 'lqt_newmessages' => 'New messages',
 291+ // Personal tool links
 292+ 'tooltip-pt-newmessages' => 'Shows new posts to threads or on threaded talk pages you are watching',
 293+ 'lqt-newmessages-n' => 'My new messages ($1)',
 294+ 'lqt_newmessages' => 'My new messages (None)',
293295 'lqt_newmessages-title' => 'New messages',
294296
295297 // Automatic summaries

Comments

#Comment by Nikerabbit (talk | contribs)   10:39, 28 March 2011

I don't like "(none)". Hiding would likely be better option. I don't like "my" either but that is less relevant.

#Comment by Purodha (talk | contribs)   22:39, 28 March 2011

Well, I don't like "my" either, but that is how all other links are named, and keeping an established style is always helpful for users (one of the things that I completely object to in LiquidThreads: it breaks MediaWikis style almost everywhere)

Hiding would have to be done via CSS. I shall dig into that later, at least hiding per user CSS should not be hard to have, imho.

Status & tagging log