r84755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84754‎ | r84755 | r84756 >
Date:18:24, 25 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
(bug 27171) Incorrect error message during extension installation. lol @ PHP's scope rules
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -1196,7 +1196,7 @@
11971197 * but we're not opening that can of worms
11981198 * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857
11991199 */
1200 - global $wgHooks, $wgAutoloadClasses;
 1200+ global $wgAutoloadClasses;
12011201 require( "$IP/includes/DefaultSettings.php" );
12021202
12031203 foreach( $exts as $e ) {
@@ -1208,8 +1208,7 @@
12091209
12101210 // Unset everyone else's hooks. Lord knows what someone might be doing
12111211 // in ParserFirstCallInit (see bug 27171)
1212 - unset( $wgHooks );
1213 - $wgHooks = array( 'LoadExtensionSchemaUpdates' => $hooksWeWant );
 1212+ $GLOBALS['wgHooks'] = array( 'LoadExtensionSchemaUpdates' => $hooksWeWant );
12141213
12151214 return Status::newGood();
12161215 }

Sign-offs

UserFlagDate
Hasharinspected12:07, 26 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r85012MFT installer changes: r84755, r84756, r84875, r84881, r84882, r84970, r84976demon14:46, 30 March 2011

Status & tagging log