r84709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84708‎ | r84709 | r84710 >
Date:21:21, 24 March 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Commiting simplest hack fix for strict errors

Instantiating new instance of UtfNormal

Will probably nee tidying up later, if we have some other instance we can normally use
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -2035,7 +2035,8 @@
20362036 */
20372037 function normalize( $s ) {
20382038 global $wgAllUnicodeFixes;
2039 - $s = UtfNormal::cleanUp( $s );
 2039+ $u = new UtfNormal;
 2040+ $s = $u->cleanUp( $s );
20402041 if ( $wgAllUnicodeFixes ) {
20412042 $s = $this->transformUsingPairFile( 'normalize-ar.ser', $s );
20422043 $s = $this->transformUsingPairFile( 'normalize-ml.ser', $s );

Follow-up revisions

RevisionCommit summaryAuthorDate
r84842Revert r84706, r84709 (UtfNormal rewrite). Clearly more work needed to get t...happy-melon12:21, 27 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84706(bug 5303) Merge UtfNormal rewrite. Patch by Ludovic Arnaud (YuviPanda). Th...happy-melon20:51, 24 March 2011

Comments

#Comment by Reedy (talk | contribs)   21:22, 24 March 2011

Follows up r84706

#Comment by Ilmari Karonen (talk | contribs)   14:52, 25 March 2011

Based on a brief look at UtfNormal.php, it seems to me that all those methods should be static anyway.

#Comment by Reedy (talk | contribs)   15:01, 25 March 2011

Quite possibly. But this was the simplest fix, rather than going and changing all the method properties....

Status & tagging log