r84698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84697‎ | r84698 | r84699 >
Date:20:02, 24 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove 2 erroneous $db parameters from External links modules
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryExtLinksUsage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExternalLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryExtLinksUsage.php
@@ -73,7 +73,7 @@
7474 $this->addWhereFld( 'page_namespace', $params['namespace'] );
7575 }
7676
77 - $whereQuery = $this->prepareUrlQuerySearchString( $db, $query, $protocol );
 77+ $whereQuery = $this->prepareUrlQuerySearchString( $query, $protocol );
7878
7979 if ( $whereQuery !== null ) {
8080 $this->addWhere( $whereQuery );
Index: trunk/phase3/includes/api/ApiQueryExternalLinks.php
@@ -59,7 +59,7 @@
6060 $this->addTables( 'externallinks' );
6161 $this->addWhereFld( 'el_from', array_keys( $this->getPageSet()->getGoodTitles() ) );
6262
63 - $whereQuery = $this->prepareUrlQuerySearchString( $db, $query, $protocol );
 63+ $whereQuery = $this->prepareUrlQuerySearchString( $query, $protocol );
6464
6565 if ( $whereQuery !== null ) {
6666 $this->addWhere( $whereQuery );

Follow-up revisions

RevisionCommit summaryAuthorDate
r84736Followup r84698, remove unused $dbreedy10:37, 25 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82915Refactor out the duplication I left with a TODO in r79659reedy21:31, 27 February 2011

Status & tagging log