r84629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84628‎ | r84629 | r84630 >
Date:19:45, 23 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
Added comments to $pageId and $rev variables within a loop to help improve code clarity
Modified paths:
  • /trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php
@@ -44,12 +44,11 @@
4545
4646 $rev = null;
4747 foreach ( $res as $i => $row ) {
 48+ // All the revs and pageIds will be the same for all rows, these are shortcuts
4849 $pageId = $row->aap_page_id;
 50+ // This is special however, because we need this data later for expired calculation
 51+ $rev = $row->aap_revision;
4952
50 - if ( is_null( $rev ) ) {
51 - $rev = $row->aap_revision;
52 - }
53 -
5453 if ( !isset( $ratings[$pageId] ) ) {
5554 $page = array(
5655 'pageid' => $pageId,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84535Step 2 of 2 for implementing expirations....tparscal17:18, 22 March 2011

Status & tagging log