r84628 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84627‎ | r84628 | r84629 >
Date:19:37, 23 March 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r83934 to unbreak the minifier
Modified paths:
  • /branches/wmf/1.17wmf1/includes/libs/JavaScriptMinifier.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/libs/JavaScriptMinifier.php
@@ -526,10 +526,11 @@
527527 $state = self::STATEMENT;
528528 $lineLength = 0;
529529 } elseif( $maxLineLength > 0 && $lineLength + $end - $pos > $maxLineLength &&
530 - !isset( $semicolon[$state][$type] ) )
 530+ !isset( $semicolon[$state][$type] ) && $type !== self::TYPE_INCR_OP )
531531 {
532532 // This line would get too long if we added $token, so add a newline first.
533 - // Only do this if it won't trigger semicolon insertion though.
 533+ // Only do this if it won't trigger semicolon insertion and if it won't
 534+ // put a postfix increment operator on its own line, which is illegal in js.
534535 $out .= "\n";
535536 $lineLength = 0;
536537 // Check, whether we have to separate the token from the last one with whitespace
Property changes on: branches/wmf/1.17wmf1/includes/libs/JavaScriptMinifier.php
___________________________________________________________________
Added: svn:mergeinfo
537538 Merged /branches/sqlite/includes/libs/JavaScriptMinifier.php:r58211-58321
538539 Merged /trunk/phase3/includes/libs/JavaScriptMinifier.php:r83590,83934
539540 Merged /branches/new-installer/phase3/includes/libs/JavaScriptMinifier.php:r43664-66004
540541 Merged /branches/wmf-deployment/includes/libs/JavaScriptMinifier.php:r53381,60970
541542 Merged /branches/REL1_15/phase3/includes/libs/JavaScriptMinifier.php:r51646
542543 Merged /branches/wmf/1.16wmf4/includes/libs/JavaScriptMinifier.php:r67177,69199,76243,77266

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83934Followup r83891: don't insert a newline before ++ or -- . Patch by Paul Coppe...catrope18:04, 14 March 2011

Status & tagging log