r84569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84568‎ | r84569 | r84570 >
Date:21:52, 22 March 2011
Author:aaron
Status:ok
Tags:
Comment:
Cast $revIdStable to an int like the others
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -641,7 +641,7 @@
642642 $revIdDraft = (int)$row->page_latest; // may be NULL
643643 if ( FlaggedRevs::inclusionSetting() == FR_INCLUDES_STABLE ) {
644644 # Select newest of (stable rev, rev when reviewed) as "version used"
645 - $revIdStable = max( $row->fp_stable, $row->ft_tmp_rev_id );
 645+ $revIdStable = (int)max( $row->fp_stable, $row->ft_tmp_rev_id );
646646 } else {
647647 $revIdStable = (int)$row->ft_tmp_rev_id; // may be NULL
648648 }
@@ -697,7 +697,7 @@
698698 __METHOD__,
699699 array(), /* OPTIONS */
700700 array(
701 - 'flaggedimages' => array( 'LEFT JOIN',
 701+ 'flaggedimages' => array( 'LEFT JOIN',
702702 array( 'fi_rev_id' => $this->getRevId(), 'fi_name = il_to' ) ),
703703 'page' => array( 'LEFT JOIN',
704704 'page_namespace = ' . NS_FILE . ' AND page_title = il_to' ),

Status & tagging log