r84568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84567‎ | r84568 | r84569 >
Date:21:49, 22 March 2011
Author:kwisatz
Status:deferred
Tags:
Comment:
fix to r82063
Modified paths:
  • /tags/extensions/GeeQuBox/REL_0_2/GeeQuBox.php (modified) (history)

Diff [purge]

Index: tags/extensions/GeeQuBox/REL_0_2/GeeQuBox.php
@@ -82,10 +82,10 @@
8383 private function _gqbAddScripts() {
8484 global $wgExtensionAssetsPath;
8585
86 - $eDir = $wgExtensionAssetsPath . '/' . basename(dirname(__FILE__));
 86+ $eDir = $wgExtensionAssetsPath . '/' . basename(dirname(__FILE__)) . '/';
8787 self::$_page->includeJQuery();
8888 self::$_page->addScript( '<script type="text/javascript" src="'
89 - . $eDir . '/js/jquery.lightbox-0.5.min.js"></script>' . PHP_EOL );
 89+ . $eDir . 'js/jquery.lightbox-0.5.min.js"></script>' . PHP_EOL );
9090 self::$_page->addExtensionStyle( $eDir . '/css/jquery.lightbox-0.5.css', 'screen' );
9191 self::$_page->addInlineScript('$j(document).ready(function(){
9292 $j("div.gallerybox").each(function(el){
@@ -121,7 +121,6 @@
122122 * approach but there doesn't seem to be an alternative approach.)
123123 */
124124 private function _gqbReplaceHref() {
125 - // determine path info
126125 global $wgArticlePath;
127126 $articlePath = substr( $wgArticlePath, 0, strpos( $wgArticlePath, '$1' ) );
128127 $pattern = '~href="'.$articlePath.'([^"]+)"\s*class="image"~';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82063GeeQuBox trunk now using ResourceLoader and compatible with mw 1.17alphakwisatz17:55, 13 February 2011

Status & tagging log