r84532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84531‎ | r84532 | r84533 >
Date:15:59, 22 March 2011
Author:demon
Status:ok
Tags:
Comment:
Cleanup r80892, r84485: Check user also in sqlite for consistency.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -245,11 +245,6 @@
246246 return 'ibm_db2';
247247 }
248248
249 - ######################################
250 - # Setup
251 - ######################################
252 -
253 -
254249 /**
255250 *
256251 * @param $server String: hostname of database server
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -26,8 +26,8 @@
2727 function __construct( $server = false, $user = false, $password = false, $dbName = false, $flags = 0 ) {
2828 $this->mName = $dbName;
2929 parent::__construct( $server, $user, $password, $dbName, $flags );
30 - // parent doesn't open when $server is false, but we can work with $dbName
31 - if( !$server && $dbName ) {
 30+ // parent doesn't open when $user is false, but we can work with $dbName
 31+ if( !$user && $dbName ) {
3232 global $wgSharedDB;
3333 if( $this->open( $server, $user, $password, $dbName ) && $wgSharedDB ) {
3434 $this->attachDatabase( $wgSharedDB );

Follow-up revisions

RevisionCommit summaryAuthorDate
r84548MFT r80892, r81143, partial r81896, r84532demon20:10, 22 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80892* Cleanup massive duplication across Database constructors. Default implement...demon18:36, 24 January 2011
r84485Do not depend on the lack of a server for connecting: Postgres has a valid an...greg21:20, 21 March 2011

Status & tagging log