r84529 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84528‎ | r84529 | r84530 >
Date:14:38, 22 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
* Bucket was set to 0 by default, but API gives warning if bucket is less than 1, now using 1 as default.
* Expiry notice was shown when the form was hidden and then shown because of a misplaced class - visible-with-form class has been moved to a new surrounding div so the notice will still show and hide without loosing it's own particular visibility state.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -33,9 +33,11 @@
3434 <button class="articleFeedback-submit articleFeedback-visibleWith-form" type="submit" disabled><html:msg key="form-panel-submit" /></button>\
3535 <div class="articleFeedback-success articleFeedback-visibleWith-form"><span><html:msg key="form-panel-success" /></span></div>\
3636 <div style="clear:both;"></div>\
37 - <div class="articleFeedback-expiry articleFeedback-visibleWith-form">\
38 - <div class="articleFeedback-expiry-title"><html:msg key="form-panel-expiry-title" /></div>\
39 - <div class="articleFeedback-expiry-message"><html:msg key="form-panel-expiry-message" /></div>\
 37+ <div class="articleFeedback-notices articleFeedback-visibleWith-form">\
 38+ <div class="articleFeedback-expiry">\
 39+ <div class="articleFeedback-expiry-title"><html:msg key="form-panel-expiry-title" /></div>\
 40+ <div class="articleFeedback-expiry-message"><html:msg key="form-panel-expiry-message" /></div>\
 41+ </div>\
4042 </div>\
4143 </div>\
4244 <div class="articleFeedback-error"><div class="articleFeedback-error-message"><html:msg key="error" /></div></div>\
@@ -602,7 +604,7 @@
603605 var context = $(this).data( 'articleFeedback-context' );
604606 if ( !context ) {
605607 // Create context
606 - context = { '$ui': $(this), 'options': { 'ratings': {}, 'pitches': {}, 'bucket': 0 } };
 608+ context = { '$ui': $(this), 'options': { 'ratings': {}, 'pitches': {}, 'bucket': 1 } };
607609 // Allow customization through an options argument
608610 if ( typeof args[0] === 'object' ) {
609611 context = $.extend( true, context, { 'options': args[0] } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r845301.17wmf1: MFT r84474, r84529catrope14:42, 22 March 2011

Status & tagging log