r84434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84433‎ | r84434 | r84435 >
Date:00:04, 21 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Change default value of $wgSiteMatrixFile not to be so WMF specific (ie null)

It's already set in CommonSettings
Modified paths:
  • /trunk/extensions/SiteMatrix/SiteMatrix.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SiteMatrix/SiteMatrix.php
——@@ -18,7 +18,7 @@
1919 'descriptionmsg' => 'sitematrix-desc',
2020 );
2121
22 -$wgSiteMatrixFile = '/apache/common/langlist';
 22+$wgSiteMatrixFile = null;
2323 $wgSiteMatrixSites = array(
2424 'wiki' => array(
2525 'name' => 'Wikipedia',

Comments

#Comment by MZMcBride (talk | contribs)   01:08, 21 March 2011

I'm not sure I see the point in this when the $wgSiteMatrixSites array is completely Wikimedia-specific still....

#Comment by 😂 (talk | contribs)   01:28, 21 March 2011

Maybe one day it could be useful to other people?

#Comment by Reedy (talk | contribs)   11:27, 21 March 2011

It wouldn't take much to get a 3rd party site to use it, just nullifying some of the core hacks etc

Status & tagging log