r84379 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84378‎ | r84379 | r84380 >
Date:13:15, 20 March 2011
Author:junaidpv
Status:ok (Comments)
Tags:
Comment:
Narayam: Reorder schemes of Malayalam, transliteration need to be first in the list box
Modified paths:
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.php
——@@ -155,16 +155,16 @@
156156 'messages' => array( 'narayam-kn-inscript' ),
157157 'dependencies' => 'ext.narayam.core',
158158 );
 159+$wgResourceModules['ext.narayam.rules.ml'] = $narayamTpl + array(
 160+ 'scripts' => 'ext.narayam.rules.ml.js',
 161+ 'messages' => array( 'narayam-ml' ),
 162+ 'dependencies' => 'ext.narayam.core',
 163+);
159164 $wgResourceModules['ext.narayam.rules.ml-inscript'] = $narayamTpl + array(
160165 'scripts' => 'ext.narayam.rules.ml-inscript.js',
161166 'messages' => array( 'narayam-ml-inscript' ),
162167 'dependencies' => 'ext.narayam.core',
163168 );
164 -$wgResourceModules['ext.narayam.rules.ml'] = $narayamTpl + array(
165 - 'scripts' => 'ext.narayam.rules.ml.js',
166 - 'messages' => array( 'narayam-ml' ),
167 - 'dependencies' => 'ext.narayam.core',
168 -);
169169 $wgResourceModules['ext.narayam.rules.or'] = $narayamTpl + array(
170170 'scripts' => 'ext.narayam.rules.or.js',
171171 'messages' => array( 'narayam-or' ),

Comments

#Comment by Catrope (talk | contribs)   20:58, 20 March 2011

Does this work? I think you need to reorder them in $wgNarayamSchemes instead.

#Comment by Junaidpv (talk | contribs)   04:14, 21 March 2011

Me too thought about it first, but $wgNarayamSchemes was already in the order we want. So I tried with this change and works! I think it effects resource loading order, but no clue about how.

#Comment by Catrope (talk | contribs)   09:58, 21 March 2011

IIRC the JS side doesn't actually enforce any kind of order, so this works more or less by accident. I'll fix that some time

Status & tagging log