r84354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84353‎ | r84354 | r84355 >
Date:22:35, 19 March 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Make filtering by author, then by path, remember the author

Fixup some whitespace too
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionAuthorView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionAuthorView.php
@@ -13,8 +13,9 @@
1414 }
1515
1616 function linkStatus() {
17 - if ( !$this->mUser )
 17+ if ( !$this->mUser ) {
1818 return wfMsg( 'code-author-orphan' );
 19+ }
1920
2021 return wfMsgHtml( 'code-author-haslink',
2122 $this->skin->userLink( $this->mUser->getId(), $this->mUser->getName() ) .
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -374,12 +374,18 @@
375375 return '-';
376376 }
377377 case 'cr_path':
 378+ $title = $this->mRepo->getName() . '/path';
 379+ if( $this->mView->mAuthor ) {
 380+ $title .= '/' . $this->mView->mAuthor;
 381+ }
 382+
378383 return Xml::openElement( 'div', array( 'title' => (string)$value ) ) .
379384 $this->mView->skin->link(
380 - SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/path' ),
381 - $wgLang->truncate( (string)$value, 50 ),
382 - array( 'title' => (string)$value ),
383 - array( 'path' => (string)$value ) ) . "</div>";
 385+ SpecialPage::getTitleFor( 'Code', $title ),
 386+ $wgLang->truncate( (string)$value, 50 ),
 387+ array( 'title' => (string)$value ),
 388+ array( 'path' => (string)$value )
 389+ ) . "</div>";
384390 }
385391 }
386392

Follow-up revisions

RevisionCommit summaryAuthorDate
r84355Foo. Fix r84354...reedy22:44, 19 March 2011

Comments

#Comment by Krinkle (talk | contribs)   22:39, 19 March 2011

Why use /author/authorname instead of &author=authorname ? Seems to be working here

#Comment by Reedy (talk | contribs)   22:43, 19 March 2011

But you don't get the explicit author filtering stuff, like you do at http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/author/krinkle

With http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki&author=krinkle we don't get it either

It's all back to Query Params in CR sucking ;)

#Comment by Reedy (talk | contribs)   22:45, 19 March 2011

That and the /path that it was using before, made no difference

Status & tagging log