r84344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84343‎ | r84344 | r84345 >
Date:20:48, 19 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Expand unit tests with bug references

Some overlaps in bugs...

A lot of it boils down to the same issue though
Modified paths:
  • /trunk/extensions/CodeReview/tests/CodeReviewTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/tests/CodeReviewTest.php
@@ -19,8 +19,24 @@
2020 $this->assertEquals( '[http://foo http://foo]', $formatter->link( 'http://foo' ) );
2121 $this->assertEquals( '[http://example.com/bugzilla/123 bug 123]', $formatter->link( 'bug 123' ) );
2222 $this->assertEquals( '[[Special:Code/Test/456|r456]]', $formatter->link( 'r456' ) );
23 - // fails, bug 23203 and so on
24 - // $this->assertEquals( '[http://example.org foo http://example.org foo]', $formatter->link( '[http://example.org foo http://example.org foo]' ) );
 23+
 24+ // fails, 18614
2525 // $this->assertEquals( '[http://foo.bar r123]', $formatter->link( '[http://foo.bar r123]' ) );
 26+ // $this->assertEquals( '[[foo|bug 1234]]', $formatter->link( '[[foo|bug 1234]]' ) );
 27+ // $this->assertEquals( '[[bugzilla:19359|bug 19359]]', $formatter->link( '[[bugzilla:19359|bug 19359]]' ) );
 28+
 29+ // fails, bug 19299
 30+ // $this->assertEquals( '[[bugzilla:18989|Bug 18989]]', $formatter->link( '[[bugzilla:18989|Bug 18989]]' ) );
 31+ // $this->assertEquals( '[http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75762#code-comments r75762 CR comments]',
 32+ // $formatter->link( [http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75762#code-comments r75762 CR comments]' ) );
 33+
 34+ // fails, bug 24279
 35+ // $this->assertEquals( '[http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?pathrev=70049&r1=70048&r2=70049 ViewVC]',
 36+ // $formatter->link( '[http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/api/ApiUpload.php?pathrev=70049&r1=70048&r2=70049 ViewVC]' ) );
 37+ // $this->assertEquals( '<nowiki>bug 24027</nowiki>', $formatter->link( '<nowiki>bug 24027</nowiki>' ) );
 38+ // $this->assertEquals( 'http://bugzilla.org/13518#c9', $formatter->link( 'bug 13518#c9' ) );
 39+ // $this->assertEquals( 'http://bugzilla.org/13518#c9', $formatter->link( 'bug 13518 comment 9' ) );
 40+
 41+ // $this->assertEquals( '', $formatter->link( '' ) );
2642 }
2743 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r84345Followup r84344...reedy20:49, 19 March 2011

Status & tagging log