r84338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84337‎ | r84338 | r84339 >
Date:17:44, 19 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Mark various internal methods as protected, which have no external calls in core or extensions.
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -275,7 +275,7 @@
276276 * @param $user Integer: if not 0, then sets ipb_anon_only
277277 * @return Boolean
278278 */
279 - public function loadRange( $address, $killExpired = true, $user = 0 ) {
 279+ protected function loadRange( $address, $killExpired = true, $user = 0 ) {
280280 $iaddr = IP::toHex( $address );
281281
282282 if ( $iaddr === false ) {
@@ -310,7 +310,7 @@
311311 *
312312 * @param $row ResultWrapper: a row from the ipblocks table
313313 */
314 - public function initFromRow( $row ) {
 314+ protected function initFromRow( $row ) {
315315 $this->mAddress = $row->ipb_address;
316316 $this->mReason = $row->ipb_reason;
317317 $this->mTimestamp = wfTimestamp( TS_MW, $row->ipb_timestamp );
@@ -492,7 +492,7 @@
493493 *
494494 * @return Boolean: whether or not a retroactive autoblock was made.
495495 */
496 - public function doRetroactiveAutoblock() {
 496+ protected function doRetroactiveAutoblock() {
497497 $dbr = wfGetDB( DB_SLAVE );
498498 # If autoblock is enabled, autoblock the LAST IP used
499499 # - stolen shamelessly from CheckUser_body.php

Status & tagging log