r84337 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84336‎ | r84337 | r84338 >
Date:17:36, 19 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r84336: break some long lines
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -147,8 +147,12 @@
148148
149149 # Try user block
150150 if ( $user ) {
151 - $res = $db->resultObject( $db->select( 'ipblocks', '*', array( 'ipb_user' => $user ),
152 - __METHOD__ ) );
 151+ $res = $db->resultObject( $db->select(
 152+ 'ipblocks',
 153+ '*',
 154+ array( 'ipb_user' => $user ),
 155+ __METHOD__
 156+ ) );
153157
154158 if ( $this->loadFromResult( $res, $killExpired ) ) {
155159 return true;
@@ -160,7 +164,12 @@
161165 # Slightly tricky while handling killExpired as well
162166 if ( $address !== '' ) {
163167 $conds = array( 'ipb_address' => $address, 'ipb_auto' => 0 );
164 - $res = $db->resultObject( $db->select( 'ipblocks', '*', $conds, __METHOD__, $options ) );
 168+ $res = $db->resultObject( $db->select(
 169+ 'ipblocks',
 170+ '*',
 171+ $conds,
 172+ __METHOD__
 173+ ) );
165174
166175 if ( $this->loadFromResult( $res, $killExpired ) ) {
167176 if ( $user && $this->mAnonOnly ) {
@@ -200,7 +209,12 @@
201210 $conds['ipb_anon_only'] = 0;
202211 }
203212
204 - $res = $db->resultObject( $db->select( 'ipblocks', '*', $conds, __METHOD__, $options ) );
 213+ $res = $db->resultObject( $db->select(
 214+ 'ipblocks',
 215+ '*',
 216+ $conds,
 217+ __METHOD__
 218+ ) );
205219
206220 if ( $this->loadFromResult( $res, $killExpired ) ) {
207221 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84336Block::forUpdate() is never called, and doesn't really make much sense in thi...happy-melon17:32, 19 March 2011

Status & tagging log