r84017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84016‎ | r84017 | r84018 >
Date:14:30, 15 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
Reverting r83962 - I misunderstood the specifications given to me.
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -31,11 +31,14 @@
3232 'articlefeedback-pitch-or',
3333 'articlefeedback-pitch-thanks',
3434 'articlefeedback-pitch-survey-message',
 35+ 'articlefeedback-pitch-survey-body',
3536 'articlefeedback-pitch-survey-accept',
3637 'articlefeedback-pitch-join-message',
 38+ 'articlefeedback-pitch-join-body',
3739 'articlefeedback-pitch-join-accept',
3840 'articlefeedback-pitch-join-login',
3941 'articlefeedback-pitch-edit-message',
 42+ 'articlefeedback-pitch-edit-body',
4043 'articlefeedback-pitch-edit-accept',
4144 'articlefeedback-survey-title',
4245 'articlefeedback-survey-message-success',
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -57,6 +57,7 @@
5858 <div class="articleFeedback-title"></div>\
5959 <div class="articleFeedback-pop">\
6060 <div class="articleFeedback-message"></div>\
 61+ <div class="articleFeedback-body"></div>\
6162 <button class="articleFeedback-accept"></button>\
6263 <button class="articleFeedback-reject"></button>\
6364 </div>\
@@ -307,6 +308,9 @@
308309 .find( '.articleFeedback-message' )
309310 .text( mw.msg( context.options.pitches[key].message ) )
310311 .end()
 312+ .find( '.articleFeedback-body' )
 313+ .text( mw.msg( context.options.pitches[key].body ) )
 314+ .end()
311315 .find( '.articleFeedback-accept' )
312316 .text( mw.msg( context.options.pitches[key].accept ) )
313317 .click( function() {
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -213,6 +213,7 @@
214214 },
215215 'title': 'articlefeedback-pitch-thanks',
216216 'message': 'articlefeedback-pitch-survey-message',
 217+ 'body': 'articlefeedback-pitch-survey-body',
217218 'accept': 'articlefeedback-pitch-survey-accept',
218219 'reject': 'articlefeedback-pitch-reject'
219220 },
@@ -235,6 +236,7 @@
236237 },
237238 'title': 'articlefeedback-pitch-thanks',
238239 'message': 'articlefeedback-pitch-join-message',
 240+ 'body': 'articlefeedback-pitch-join-body',
239241 'accept': 'articlefeedback-pitch-join-accept',
240242 'reject': 'articlefeedback-pitch-reject',
241243 // Special alternative action for going to login page
@@ -281,6 +283,7 @@
282284 },
283285 'title': 'articlefeedback-pitch-thanks',
284286 'message': 'articlefeedback-pitch-edit-message',
 287+ 'body': 'articlefeedback-pitch-join-body',
285288 'accept': 'articlefeedback-pitch-edit-accept',
286289 'reject': 'articlefeedback-pitch-reject'
287290 }
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -54,11 +54,14 @@
5555 'articlefeedback-pitch-or' => 'or',
5656 'articlefeedback-pitch-thanks' => 'Thanks! Your ratings have been saved.',
5757 'articlefeedback-pitch-survey-message' => 'Please take a moment to complete a short survey.',
 58+ 'articlefeedback-pitch-survey-body' => '',
5859 'articlefeedback-pitch-survey-accept' => 'Start survey',
5960 'articlefeedback-pitch-join-message' => 'Did you want to create an account?',
 61+ 'articlefeedback-pitch-join-body' => 'An account will help you track your edits, get involved in discussions, and be a part of the community.',
6062 'articlefeedback-pitch-join-accept' => 'Create an account',
6163 'articlefeedback-pitch-join-login' => 'Log in',
6264 'articlefeedback-pitch-edit-message' => 'Did you know that you can edit this page?',
 65+ 'articlefeedback-pitch-edit-body' => '',
6366 'articlefeedback-pitch-edit-accept' => 'Edit this page',
6467 'articlefeedback-survey-message-success' => 'Thanks for filling out the survey.',
6568 'articlefeedback-survey-message-error' => 'An error has occurred.

Follow-up revisions

RevisionCommit summaryAuthorDate
r84021Follow-up r84017 for Translatewikiraymond15:06, 15 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83962Removed body text from pitches.tparscal20:55, 14 March 2011

Status & tagging log