r84004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84003‎ | r84004 | r84005 >
Date:08:37, 15 March 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Follow-up r83909: Use 'parentheses' message for consistency instead of hardcoded []
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockList.php
——@@ -325,7 +325,7 @@
326326 $formatted .= ' ' . Html::rawElement(
327327 'span',
328328 array( 'class' => 'mw-blocklist-actions' ),
329 - "[{$wgLang->pipeList($links)}]"
 329+ wfMsg( 'parentheses', $wgLang->pipeList( $links ) )
330330 );
331331 }
332332 break;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83909Complete the trinity of blocking frontend interfaces by rewriting SpecialIpbl...happy-melon16:09, 14 March 2011

Comments

#Comment by Happy-melon (talk | contribs)   11:32, 15 March 2011

I was intending to follow the (admittedly somewhat ephemeral) convention of using round brackets for "look at me" links (diff, hist, etc) and square brackets for "action" links (rollback, patrol, etc).

#Comment by Raymond (talk | contribs)   12:52, 15 March 2011

Ohh... I was not aware of such a convention. In my eyes the [] looked weird in the table cell.

Status & tagging log