r84002 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84001‎ | r84002 | r84003 >
Date:07:21, 15 March 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Fix bug 28053. Just move createacount link stuff out of the ipinheader spot to where it should be.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -683,12 +683,12 @@
684684 'active' => ( $pageurl == $href )
685685 );
686686 $personal_urls['anonlogin'] = $login_url;
687 - if ( isset($createaccount_url) ) {
688 - $personal_urls['createaccount'] = $createaccount_url;
689 - }
690687 } else {
691688 $personal_urls['login'] = $login_url;
692689 }
 690+ if ( isset($createaccount_url) ) {
 691+ $personal_urls['createaccount'] = $createaccount_url;
 692+ }
693693 }
694694
695695 wfRunHooks( 'PersonalUrls', array( &$personal_urls, &$title ) );

Comments

#Comment by Aaron Schulz (talk | contribs)   01:49, 16 June 2011

Why was it there?...

#Comment by Dantman (talk | contribs)   05:19, 16 June 2011

Simple... I originally essentially put the $personal_urls['createaccount'] = $createaccount_url; right after the $personal_urls['anonlogin'] = $login_url; where it seamed to fit, but didn't notice the other $personal_urls['login'] = $login_url; for another case.

Status & tagging log