r83960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83959‎ | r83960 | r83961 >
Date:20:46, 14 March 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Fix for r83909: Add new messag to avoid lt;blocklist> on Special:SpecialPages
rename the corresponding -summary message
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2084,6 +2084,7 @@
20852085 'unblocked',
20862086 'unblocked-range',
20872087 'unblocked-id',
 2088+ 'blocklist',
20882089 'ipblocklist',
20892090 'ipblocklist-legend',
20902091 'blocklist-userblocks',
@@ -2095,7 +2096,7 @@
20962097 'blocklist-by',
20972098 'blocklist-params',
20982099 'blocklist-reason',
2099 - 'ipblocklist-summary',
 2100+ 'blocklist-summary',
21002101 'ipblocklist-submit',
21012102 'ipblocklist-localblock',
21022103 'ipblocklist-otherblocks',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -140,7 +140,7 @@
141141 'allpages-summary',
142142 'booksources-summary',
143143 'categories-summary',
144 - 'ipblocklist-summary',
 144+ 'blocklist-summary',
145145 'protectedtitles-summary',
146146 'listusers-summary',
147147 'longpages-summary',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3070,6 +3070,7 @@
30713071 'unblocked' => '[[User:$1|$1]] has been unblocked',
30723072 'unblocked-range' => '$1 has been unblocked',
30733073 'unblocked-id' => 'Block $1 has been removed',
 3074+'blocklist' => 'Blocked IP addresses and usernames',
30743075 'ipblocklist' => 'Blocked IP addresses and usernames',
30753076 'ipblocklist-legend' => 'Find a blocked user',
30763077 'blocklist-userblocks' => 'Hide account blocks',

Follow-up revisions

RevisionCommit summaryAuthorDate
r83963Fix for r83909: rename the corresponding -summary message. Forgotten to Crtl-...raymond21:00, 14 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83909Complete the trinity of blocking frontend interfaces by rewriting SpecialIpbl...happy-melon16:09, 14 March 2011

Comments

#Comment by Nikerabbit (talk | contribs)   21:07, 14 March 2011

Is ipblocklist still used?

#Comment by Raymond (talk | contribs)   21:11, 14 March 2011

Yes:

$wgOut->setPageTitle( wfMsg( 'ipblocklist' ) );

Maybe this can be changed to 'blocklist' as title?

#Comment by Happy-melon (talk | contribs)   21:13, 14 March 2011

I'm all up for changing all the message keys, but thought that might be somewhat gratuitous B/C breaking... :D

Status & tagging log