r83883 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83882‎ | r83883 | r83884 >
Date:11:07, 14 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r83849, fix join to be on indexed user_name
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -119,7 +119,7 @@
120120 $this->addTables( 'recentchanges' );
121121
122122 $this->addJoinConds( array( 'recentchanges' => array(
123 - 'INNER JOIN', 'rc_user=user_id'
 123+ 'INNER JOIN', 'rc_user_text=user_name'
124124 ) ) );
125125
126126 $this->addFields( 'COUNT(*) AS recentedits' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83849* (bug 26630) Add api for Special:ActiveUsers...reedy19:07, 13 March 2011
r83851Add missing group by from r83849 per Bryanreedy19:35, 13 March 2011

Status & tagging log