r83851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83850‎ | r83851 | r83852 >
Date:19:35, 13 March 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Add missing group by from r83849 per Bryan
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
——@@ -127,6 +127,8 @@
128128 $this->addWhere( "rc_log_type IS NULL OR rc_log_type != 'newusers'" );
129129 $timestamp = $db->timestamp( wfTimestamp( TS_UNIX ) - $wgActiveUserDays*24*3600 );
130130 $this->addWhere( "rc_timestamp >= {$db->addQuotes( $timestamp )}" );
 131+
 132+ $this->addOption( 'GROUP BY', 'user_name' );
131133 }
132134
133135 $this->addOption( 'LIMIT', $sqlLimit );

Follow-up revisions

RevisionCommit summaryAuthorDate
r83883Followup r83849, fix join to be on indexed user_namereedy11:07, 14 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83849* (bug 26630) Add api for Special:ActiveUsers...reedy19:07, 13 March 2011

Comments

#Comment by Bryan (talk | contribs)   18:31, 26 March 2011

Needs fixing per Roan's comment on r83849.

#Comment by Reedy (talk | contribs)   18:34, 26 March 2011

I did in r83883 ? :S

#Comment by Bryan (talk | contribs)   18:36, 26 March 2011

It was not marked as a follow up :p

#Comment by Reedy (talk | contribs)   18:36, 26 March 2011

It is on the original :P

Status & tagging log