r83870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83869‎ | r83870 | r83871 >
Date:04:31, 14 March 2011
Author:tstarling
Status:ok
Tags:
Comment:
Revert r79130, equivalent to trunk r83868: use the same cache before and after page save, to make sure the user sees the updated version immediately after save.
Modified paths:
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/Article.php
@@ -41,7 +41,7 @@
4242 var $mTouched = '19700101000000'; // !<
4343 var $mUser = -1; // !< Not loaded
4444 var $mUserText = ''; // !< username from Revision if set
45 - var $mParserOptions; // !< ParserOptions object for $wgUser articles
 45+ var $mParserOptions; // !< ParserOptions object
4646 var $mParserOutput; // !< ParserCache object if set
4747 /**@}}*/
4848
@@ -3596,7 +3596,7 @@
35973597 $edit->revid = $revid;
35983598 $edit->newText = $text;
35993599 $edit->pst = $this->preSaveTransform( $text );
3600 - $edit->popts = $this->getParserOptions( true );
 3600+ $edit->popts = $this->getParserOptions();
36013601 $edit->output = $wgParser->parse( $edit->pst, $this->mTitle, $edit->popts, true, true, $revid );
36023602 $edit->oldText = $this->getContent();
36033603
@@ -4437,23 +4437,15 @@
44384438
44394439 /**
44404440 * Get parser options suitable for rendering the primary article wikitext
4441 - * @param $canonical boolean Determines that the generated must not depend on user preferences (see bug 14404)
44424441 * @return mixed ParserOptions object or boolean false
44434442 */
4444 - public function getParserOptions( $canonical = false ) {
4445 - global $wgUser, $wgLanguageCode;
 4443+ public function getParserOptions() {
 4444+ global $wgUser;
44464445
4447 - if ( !$this->mParserOptions || $canonical ) {
4448 - $user = !$canonical ? $wgUser : new User;
4449 - $parserOptions = new ParserOptions( $user );
4450 - $parserOptions->setTidy( true );
4451 - $parserOptions->enableLimitReport();
4452 -
4453 - if ( $canonical ) {
4454 - $parserOptions->setUserLang( $wgLanguageCode ); # Must be set explicitely
4455 - return $parserOptions;
4456 - }
4457 - $this->mParserOptions = $parserOptions;
 4446+ if ( !$this->mParserOptions ) {
 4447+ $this->mParserOptions = new ParserOptions( $wgUser );
 4448+ $this->mParserOptions->setTidy( true );
 4449+ $this->mParserOptions->enableLimitReport();
44584450 }
44594451
44604452 // Clone to allow modifications of the return value without affecting
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -484,9 +484,6 @@
485485 as wikitext on preview.
486486 * Page existence is now not revealed (in the colour of the tabs) to users who cannot
487487 read the page in question.
488 -* (bug 14404) The articles are now always saved with the default options. Articles
489 - with {{int:X}} will have consistent table links no matter the preferences of the
490 - last saving user.
491488 * (bug 22753) Output from update.php is more clear when things changed, entries
492489 indicating nothing changed are now all prefixed by "..."
493490 * (bug 16019) $wgArticlePath = "/$1" no longer breaks API edit/watch actions

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79130MFT r79122 + RELEASE-NOTESplatonides20:00, 28 December 2010
r83868Revert r79122, causes bug 27891 (old version seen immediately after edit).tstarling04:26, 14 March 2011

Status & tagging log