r83869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83868‎ | r83869 | r83870 >
Date:04:29, 14 March 2011
Author:tstarling
Status:ok
Tags:
Comment:
Revert r79130, equivalent to trunk r83868: use the same cache before and after page save, to make sure the user sees the updated version immediately after save.
Modified paths:
  • /branches/wmf/1.17wmf1/RELEASE-NOTES (modified) (history)
  • /branches/wmf/1.17wmf1/includes/Article.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/Article.php
@@ -41,7 +41,7 @@
4242 var $mTouched = '19700101000000'; // !<
4343 var $mUser = -1; // !< Not loaded
4444 var $mUserText = ''; // !< username from Revision if set
45 - var $mParserOptions; // !< ParserOptions object for $wgUser articles
 45+ var $mParserOptions; // !< ParserOptions object
4646 var $mParserOutput; // !< ParserCache object if set
4747 /**@}}*/
4848
@@ -3582,7 +3582,7 @@
35833583 $edit->revid = $revid;
35843584 $edit->newText = $text;
35853585 $edit->pst = $this->preSaveTransform( $text );
3586 - $edit->popts = $this->getParserOptions( true );
 3586+ $edit->popts = $this->getParserOptions();
35873587 $edit->output = $wgParser->parse( $edit->pst, $this->mTitle, $edit->popts, true, true, $revid );
35883588 $edit->oldText = $this->getContent();
35893589
@@ -4423,23 +4423,15 @@
44244424
44254425 /**
44264426 * Get parser options suitable for rendering the primary article wikitext
4427 - * @param $canonical boolean Determines that the generated must not depend on user preferences (see bug 14404)
44284427 * @return mixed ParserOptions object or boolean false
44294428 */
4430 - public function getParserOptions( $canonical = false ) {
4431 - global $wgUser, $wgLanguageCode;
 4429+ public function getParserOptions() {
 4430+ global $wgUser;
44324431
4433 - if ( !$this->mParserOptions || $canonical ) {
4434 - $user = !$canonical ? $wgUser : new User;
4435 - $parserOptions = new ParserOptions( $user );
4436 - $parserOptions->setTidy( true );
4437 - $parserOptions->enableLimitReport();
4438 -
4439 - if ( $canonical ) {
4440 - $parserOptions->setUserLang( $wgLanguageCode ); # Must be set explicitely
4441 - return $parserOptions;
4442 - }
4443 - $this->mParserOptions = $parserOptions;
 4432+ if ( !$this->mParserOptions ) {
 4433+ $this->mParserOptions = new ParserOptions( $wgUser );
 4434+ $this->mParserOptions->setTidy( true );
 4435+ $this->mParserOptions->enableLimitReport();
44444436 }
44454437
44464438 // Clone to allow modifications of the return value without affecting
Index: branches/wmf/1.17wmf1/RELEASE-NOTES
@@ -476,9 +476,6 @@
477477 as wikitext on preview.
478478 * Page existence is now not revealed (in the colour of the tabs) to users who cannot
479479 read the page in question.
480 -* (bug 14404) The articles are now always saved with the default options. Articles
481 - with {{int:X}} will have consistent table links no matter the preferences of the
482 - last saving user.
483480 * (bug 22753) Output from update.php is more clear when things changed, entries
484481 indicating nothing changed are now all prefixed by "..."
485482 * (bug 16019) $wgArticlePath = "/$1" no longer breaks API edit/watch actions

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79130MFT r79122 + RELEASE-NOTESplatonides20:00, 28 December 2010
r83868Revert r79122, causes bug 27891 (old version seen immediately after edit).tstarling04:26, 14 March 2011

Status & tagging log