r83862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83861‎ | r83862 | r83863 >
Date:23:04, 13 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 27585) add pagecount to list=filearchive
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryFilearchive.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryFilearchive.php
@@ -140,6 +140,11 @@
141141 }
142142 if ( $fld_size ) {
143143 $file['size'] = $row->fa_size;
 144+
 145+ $pageCount = ArchivedFile::newFromRow( $row )->pageCount();
 146+ if ( $pageCount !== false ) {
 147+ $vals['pagecount'] = $pageCount;
 148+ }
144149 }
145150 if ( $fld_dimensions ) {
146151 $file['height'] = $row->fa_height;
Index: trunk/phase3/RELEASE-NOTES
@@ -115,7 +115,7 @@
116116 * (bug 2581, bug 6834) Added links to thumbnail in several resolutions to the
117117 file description page. The sizes are set by $wgImageLimits.
118118 * (bug 28031) Add pageCount support to ArchivedFile
119 -
 119+
120120 === Bug fixes in 1.18 ===
121121 * (bug 23119) WikiError class and subclasses are now marked as deprecated
122122 * (bug 10871) Javascript and CSS pages in MediaWiki namespace are no longer
@@ -257,6 +257,7 @@
258258 * (bug 27020) API: Allow title prefix search of logevents (only when not in
259259 miser mode)
260260 * (bug 26629) add Special:MIMESearch to api
 261+* (bug 27585) add pagecount to list=filearchive
261262
262263 === Languages updated in 1.18 ===
263264

Follow-up revisions

RevisionCommit summaryAuthorDate
r84260Followup r83862, add notation that page count will be added if appropriatereedy19:55, 18 March 2011

Comments

#Comment by Duplicatebug (talk | contribs)   19:33, 14 March 2011

Please update description (see r82477)

Status & tagging log