r83820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83819‎ | r83820 | r83821 >
Date:11:24, 13 March 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Fix for r83698: pass the Title object to the skin so that we are sure to show the correct context
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1847,7 +1847,7 @@
18481848 if ( $this->mArticleBodyOnly ) {
18491849 $this->out( $this->mBodytext );
18501850 } else {
1851 - $sk = $wgUser->getSkin();
 1851+ $sk = $wgUser->getSkin( $this->getTitle() );
18521852
18531853 // Hook that allows last minute changes to the output page, e.g.
18541854 // adding of CSS or Javascript by extensions.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83698Only call User::getSkin() when necessary....ialex14:31, 11 March 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   16:48, 16 June 2011

Not sure why that broke.

Status & tagging log