r83620 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83619‎ | r83620 | r83621 >
Date:00:25, 10 March 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
fix for Bug 27669
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -274,6 +274,7 @@
275275 vertical-align: middle;
276276 }
277277 #siteNotice {
 278+ position: relative;
278279 text-align: center;
279280 font-size: 95%;
280281 padding: 0 0.9em;
Index: trunk/phase3/skins/Vector.php
@@ -146,9 +146,11 @@
147147 <!-- /firstHeading -->
148148 <!-- bodyContent -->
149149 <div id="bodyContent">
 150+ <?php if ( $this->data['isarticle'] ): ?>
150151 <!-- tagline -->
151152 <div id="siteSub"><?php $this->msg( 'tagline' ) ?></div>
152153 <!-- /tagline -->
 154+ <?php endif; ?>
153155 <!-- subtitle -->
154156 <div id="contentSub"<?php $this->html('userlangattributes') ?>><?php $this->html( 'subtitle' ) ?></div>
155157 <!-- /subtitle -->

Sign-offs

UserFlagDate
Krinkleinspected00:51, 10 March 2011

Comments

#Comment by Kaldari (talk | contribs)   00:31, 10 March 2011

Forgot to mention it in the commit comment, but the monobook fix is to bring monobook into parity with vector for how siteNotices are displayed. This was fixed in vector a long time ago, but I forgot to fix it in monobook as well at the time. This should keep CentralNotice banner links and buttons from appearing in wonky places on the page. Sorry to combine the two issue in one commit. It was an accident :)

Status & tagging log