r83602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83601‎ | r83602 | r83603 >
Date:19:11, 9 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
Added more explicit logic, javascript was evaluating '0' to true, causing people in bucket 0 to get tracked, a waste of resources.
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.js
——@@ -20,7 +20,7 @@
2121 }
2222 }
2323 }
24 -if ( bucket ) {
 24+if ( bucket > 0 ) {
2525 // Transform the targets of section edit links to route through the click tracking API
2626 $( 'span.editsection a' ).each( function() {
2727 var session = $.cookie( 'clicktracking-session' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r836041.17wmf1: MFT r83602catrope19:15, 9 March 2011

Status & tagging log