r83471 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83470‎ | r83471 | r83472 >
Date:18:46, 7 March 2011
Author:catrope
Status:ok
Tags:
Comment:
Vector/SectionEditLinks tweaks:
* Add @embed for images
* Apply cookie to entire domain and make it last for 30 days
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.css (modified) (history)
  • /trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.css
@@ -4,10 +4,12 @@
55 }
66 span.vector-editLink a {
77 padding-left: 18px;
 8+ /* @embed */
89 background-image: url(images/edit-faded.png);
910 background-position: left top;
1011 background-repeat: no-repeat;
1112 }
1213 span.vector-editLink a:hover {
 14+ /* @embed */
1315 background-image: url(images/edit.png);
1416 }
Index: trunk/extensions/Vector/modules/ext.vector.sectionEditLinks.js
@@ -12,7 +12,7 @@
1313 ) );
1414 // 0 = not tracked, 1 = tracked with old version, 2 = tracked with new version
1515 bucket = ( Math.random() * 100 ) < odds ? Number( Math.random() < 0.5 ) + 1 : 0;
16 - $.cookie( 'ext.vector.sectionEditLinks-bucket', bucket );
 16+ $.cookie( 'ext.vector.sectionEditLinks-bucket', bucket, { 'path': '/', 'expires': 30 } );
1717 // If we are going to track this person from now on, let's also track which bucket we put
1818 // them into and when
1919 if ( bucket > 0 && 'trackActionWithInfo' in $ ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r836061.17wmf1: MFT r83471catrope19:37, 9 March 2011

Status & tagging log