r83434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83433‎ | r83434 | r83435 >
Date:04:04, 7 March 2011
Author:bawolff
Status:ok
Tags:
Comment:
(follow-up r63291). *head* -> *wall*. Add forgotten variable that caused invalid html with extra </li> (not noticable with tidy on).

Also fixes one of the two broken tests I added in r83433. The other one will have to wait for another day.
Modified paths:
  • /trunk/extensions/intersection/DynamicPageList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/intersection/DynamicPageList.php
——@@ -209,6 +209,7 @@
210210 $sStartList = '';
211211 $sEndList = '';
212212 $sStartItem = '';
 213+ $sEndItem = '';
213214 $bInlineMode = true;
214215 break;
215216 case 'unordered':

Follow-up revisions

RevisionCommit summaryAuthorDate
r83435(follow-up r83434) Didn't mean to commit so fast. Fix the test for this exten...bawolff04:13, 7 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63291Bug 8886 - add an inline list mode to intersectionbawolff21:15, 5 March 2010
r83433Add parser tests to this extension....bawolff03:41, 7 March 2011

Status & tagging log