r83432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83431‎ | r83432 | r83433 >
Date:02:36, 7 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r83369
Modified paths:
  • /branches/SemanticMaps0.8/includes/services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/GoogleMaps3/SM_GoogleMaps3QP.php (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/OpenLayers/SM_OpenLayersQP.php (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: branches/SemanticMaps0.8/includes/services/GoogleMaps/SM_GoogleMapsQP.php
@@ -27,24 +27,4 @@
2828 . parent::getMapHTML( $params, $parser, $mapName );
2929 }
3030
31 - /**
32 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the
33 - * specific ones to the list.
34 - *
35 - * @return array
36 - */
37 - public function getParameters() {
38 - $params = parent::getParameters();
39 -
40 - $allowedTypes = array_keys( MapsGoogleMaps::$mapTypes );
41 -
42 - $params[] = array( 'name' => 'controls', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_controls' ), 'values' => MapsGoogleMaps::getControlNames() );
43 - $params[] = array( 'name' => 'types', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_types' ), 'values' => $allowedTypes );
44 - $params[] = array( 'name' => 'type', 'type' => 'enumeration', 'description' => wfMsg( 'semanticmaps_paramdesc_type' ), 'values' => $allowedTypes );
45 - $params[] = array( 'name' => 'overlays', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_overlays' ), 'values' => MapsGoogleMaps::getOverlayNames() );
46 - $params[] = array( 'name' => 'autozoom', 'type' => 'enumeration', 'description' => wfMsg( 'semanticmaps_paramdesc_autozoom' ), 'values' => array( 'on', 'off' ) );
47 -
48 - return $params;
49 - }
50 -
5131 }
Index: branches/SemanticMaps0.8/includes/services/GoogleMaps3/SM_GoogleMaps3QP.php
@@ -17,18 +17,4 @@
1818 return 'googlemaps3';
1919 }
2020
21 - /**
22 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the
23 - * specific ones to the list.
24 - *
25 - * @return array
26 - */
27 - public function getParameters() {
28 - $params = parent::getParameters();
29 -
30 - // TODO
31 -
32 - return $params;
33 - }
34 -
3521 }
Index: branches/SemanticMaps0.8/includes/services/YahooMaps/SM_YahooMapsQP.php
@@ -16,24 +16,5 @@
1717 protected function getServiceName() {
1818 return 'yahoomaps';
1919 }
20 -
21 - /**
22 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the
23 - * specific ones to the list.
24 - *
25 - * @return array
26 - */
27 - public function getParameters() {
28 - $params = parent::getParameters();
29 -
30 - $allowedTypes = MapsYahooMaps::getTypeNames();
31 -
32 - $params[] = array( 'name' => 'controls', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_controls' ), 'values' => MapsYahooMaps::getControlNames() );
33 - $params[] = array( 'name' => 'types', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_types' ), 'values' => $allowedTypes );
34 - $params[] = array( 'name' => 'type', 'type' => 'enumeration', 'description' => wfMsg( 'semanticmaps_paramdesc_type' ), 'values' => $allowedTypes );
35 - $params[] = array( 'name' => 'autozoom', 'type' => 'enumeration', 'description' => wfMsg( 'semanticmaps_paramdesc_autozoom' ), 'values' => array( 'on', 'off' ) );
36 -
37 - return $params;
38 - }
3920
4021 }
Index: branches/SemanticMaps0.8/includes/services/OpenLayers/SM_OpenLayersQP.php
@@ -17,19 +17,4 @@
1818 return 'openlayers';
1919 }
2020
21 - /**
22 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the
23 - * specific ones to the list.
24 - *
25 - * @return array
26 - */
27 - public function getParameters() {
28 - $params = parent::getParameters();
29 -
30 - $params[] = array( 'name' => 'controls', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_controls' ), 'values' => MapsOpenLayers::getControlNames() );
31 - $params[] = array( 'name' => 'layers', 'type' => 'enum-list', 'description' => wfMsg( 'semanticmaps_paramdesc_layers' ), 'values' => MapsOpenLayers::getLayerNames() );
32 -
33 - return $params;
34 - }
35 -
3621 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83369matching changes in r83368jeroendedauw04:52, 6 March 2011

Status & tagging log