r83422 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83421‎ | r83422 | r83423 >
Date:23:29, 6 March 2011
Author:platonides
Status:ok
Tags:
Comment:
Reorder so that wfProfileOut() is the last sentence before the return.
Modified paths:
  • /trunk/phase3/includes/objectcache/MemcachedClient.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/objectcache/MemcachedClient.php
@@ -431,12 +431,12 @@
432432 }
433433 }
434434
435 - wfProfileOut( __METHOD__ );
 435+ $value = false;
436436 if ( isset( $val[$key] ) ) {
437 - return $val[$key];
438 - } else {
439 - return false;
 437+ $value = $val[$key];
440438 }
 439+ wfProfileOut( __METHOD__ );
 440+ return $value;
441441 }
442442
443443 // }}}

Status & tagging log