r83422 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r83421
|
r83422
|
r83423
>
Date:
23:29, 6 March 2011
Author:
platonides
Status:
ok
Tags:
Comment:
Reorder so that wfProfileOut() is the last sentence before the return.
Modified paths:
/trunk/phase3/includes/objectcache/MemcachedClient.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/objectcache/MemcachedClient.php
—
—
@@ -431,12 +431,12 @@
432
432
}
433
433
}
434
434
435
- wfProfileOut( __METHOD__ );
435
+ $value = false;
436
436
if ( isset( $val[$key] ) ) {
437
- return $val[$key];
438
- } else {
439
- return false;
437
+ $value = $val[$key];
440
438
}
439
+ wfProfileOut( __METHOD__ );
440
+ return $value;
441
441
}
442
442
443
443
// }}}
Status & tagging log
09:48, 7 March 2011
Hashar
(
talk
|
contribs
)
changed the
status
of r83422
[
removed:
new
added:
ok]