r83421 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83420‎ | r83421 | r83422 >
Date:23:28, 6 March 2011
Author:platonides
Status:ok
Tags:
Comment:
Remove unused globals
Modified paths:
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/parser/MediaWikiParserTest.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Modern.php
@@ -46,7 +46,6 @@
4747 * @access private
4848 */
4949 function execute() {
50 - global $wgRequest;
5150 $this->skin = $skin = $this->data['skin'];
5251
5352 // Suppress warnings to prevent notices about missing indexes in $this->data
Index: trunk/phase3/tests/phpunit/includes/parser/MediaWikiParserTest.php
@@ -15,7 +15,7 @@
1616 class MediaWikiParserTest {
1717
1818 public static function suite() {
19 - global $IP, $wgParserTestFiles;
 19+ global $wgParserTestFiles;
2020
2121 $suite = new PHPUnit_Framework_TestSuite;
2222
Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
@@ -592,7 +592,7 @@
593593 * Get a Parser object
594594 */
595595 function getParser( $preprocessor = null ) {
596 - global $wgParserConf, $wgHooks;
 596+ global $wgParserConf;
597597
598598 $class = $wgParserConf['class'];
599599 $parser = new $class( array( 'preprocessorClass' => $preprocessor ) + $wgParserConf );

Status & tagging log