r83401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83400‎ | r83401 | r83402 >
Date:20:20, 6 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r83399, add back base conversion
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryFilearchive.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryFilearchive.php
@@ -135,7 +135,7 @@
136136 self::addTitleInfo( $file, Title::makeTitle( NS_FILE, $row->fa_name ) );
137137
138138 if ( $fld_sha1 ) {
139 - $file['sha1'] = LocalRepo::getHashFromKey( $row->fa_storage_key );
 139+ $file['sha1'] = wfBaseConvert( LocalRepo::getHashFromKey( $row->fa_storage_key ), 36, 16, 40 );
140140 }
141141 if ( $fld_timestamp ) {
142142 $file['timestamp'] = wfTimestamp( TS_ISO_8601, $row->fa_timestamp );
@@ -155,7 +155,9 @@
156156 $file['description'] = $row->fa_description;
157157 }
158158 if ( $fld_metadata ) {
159 - $file['metadata'] = $row->fa_metadata ? ApiQueryImageInfo::processMetaData( unserialize( $row->fa_metadata ), $result ) : null;
 159+ $file['metadata'] = $row->fa_metadata
 160+ ? ApiQueryImageInfo::processMetaData( unserialize( $row->fa_metadata ), $result )
 161+ : null;
160162 }
161163 if ( $fld_bitdepth ) {
162164 $file['bitdepth'] = $row->fa_bits;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83399* (bug 27588) list=filearchive&faprop=sha1 returns empty attribute...reedy20:05, 6 March 2011

Comments

#Comment by Bryan (talk | contribs)   21:22, 6 March 2011

All your bases are belong to us

Status & tagging log