r83322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83321‎ | r83322 | r83323 >
Date:19:57, 5 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Default mPath to be an array if the gotten path is ''

So we can browse the whole repo if no path set
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -15,7 +15,13 @@
1616 parent::__construct( $repo );
1717 global $wgRequest;
1818
19 - $this->mPath = array_map( array( $this, 'preparePaths' ), explode( '|', $wgRequest->getVal( 'path' ) ) );
 19+ $path = $wgRequest->getVal( 'path' );
 20+
 21+ if ( $path != '' ) {
 22+ $this->mPath = array_map( array( $this, 'preparePaths' ), explode( '|', $path ) );
 23+ } else {
 24+ $this->mPath = array();
 25+ }
2026
2127 $this->mAuthor = $wgRequest->getText( 'author' );
2228 $this->mAppliedFilter = null;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83294* (bug 19007) Allow (delimited) list of paths in Special:Code filterreedy16:05, 5 March 2011

Comments

#Comment by Reedy (talk | contribs)   19:58, 5 March 2011

Follows up r83322

Status & tagging log