r83316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83315‎ | r83316 | r83317 >
Date:19:40, 5 March 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26120) CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

Done for comments/status changes
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -145,7 +145,10 @@
146146 'codereview-email-body' => 'User "$1" posted a comment on $3.
147147
148148 Full URL: $2
 149+Commit summary:
149150
 151+$5
 152+
150153 Comment:
151154
152155 $4',
@@ -169,8 +172,11 @@
170173 Old Status: $3
171174 New Status: $4
172175
173 -Full URL: $5',
 176+Full URL: $5
 177+Commit summary:
174178
 179+$6',
 180+
175181 'codereview-email-subj4' => '[$1 $2]: New comment added, and revision status changed',
176182 'codereview-email-body4' => 'User "$1" changed the status of $2.
177183
@@ -180,7 +186,10 @@
181187 User "$1" also posted a comment on $2.
182188
183189 Full URL: $5
 190+Commit summary:
184191
 192+$7
 193+
185194 Comment:
186195
187196 $6',
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -121,16 +121,17 @@
122122 if ( $statusChanged && $commentAdded ) {
123123 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj4', 'codereview-email-body4',
124124 $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(),
125 - $this->mRev->getStatus(), $url, $this->text
 125+ $this->mRev->getStatus(), $url, $this->text, $this->mRev->getMessage()
126126 );
127127 } else if ( $statusChanged ) {
128128 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj3', 'codereview-email-body3',
129129 $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(),
130 - $this->mRev->getStatus(), $url
 130+ $this->mRev->getStatus(), $url, $this->mRev->getMessage()
131131 );
132132 } else if ( $commentAdded ) {
133133 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj', 'codereview-email-body',
134 - $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text
 134+ $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text,
 135+ $this->mRev->getMessage()
135136 );
136137 }
137138 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83315* (bug 26120) CodeReview e-mails (for new comments, follow-up revisions, etc....reedy19:36, 5 March 2011

Status & tagging log