r83315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83314‎ | r83315 | r83316 >
Date:19:36, 5 March 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26120) CodeReview e-mails (for new comments, follow-up revisions, etc.) should include commit summary of original revision for context

Fixed for followup revisions. Rearranged the message, again...

Adding in addition of commit summary from the revision that is being followed up for context
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -420,6 +420,8 @@
421421
422422 $revisionAuthor = $revision->getWikiUser();
423423
 424+ $revisionCommitSummary = $revision->getMessage();
 425+
424426 //Add the followup revision author if they have not already been added as a commentor (they won't want dupe emails!)
425427 if ( !array_key_exists( $revisionAuthor->getId(), $users ) ) {
426428 $users[$revisionAuthor->getId()] = $revisionAuthor;
@@ -439,7 +441,9 @@
440442 wfMsgExt( 'codereview-email-subj2', $lang, $this->repo->getName(),
441443 $this->getIdString( $row->cr_id ) ),
442444 wfMsgExt( 'codereview-email-body2', $lang, $committer,
443 - $this->getIdStringUnique( $row->cr_id ), $url, $this->message, $rowUrl )
 445+ $this->getIdStringUnique( $row->cr_id ),
 446+ $url, $this->message,
 447+ $rowUrl, $revisionCommitSummary )
444448 );
445449 }
446450 }
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -153,10 +153,12 @@
154154 'codereview-email-subj2' => '[$1 $2]: Follow-up changes',
155155 'codereview-email-body2' => 'User "$1" made follow-up changes to $2.
156156
157 -Full URL: $3
158 -
159157 Full URL for followed up revision: $5
 158+Commit summary:
160159
 160+$6
 161+
 162+Full URL: $3
161163 Commit summary:
162164
163165 $4',
@@ -182,7 +184,7 @@
183185 Comment:
184186
185187 $6',
186 -
 188+
187189 'code-stats' => 'statistics',
188190 'code-stats-header' => 'Statistics for repository $1',
189191 'code-stats-main' => 'As of $1, the repository has $2 {{PLURAL:$2|revision|revisions}} by [[Special:Code/$3/author|$4 {{PLURAL:$4|author|authors}}]].',

Follow-up revisions

RevisionCommit summaryAuthorDate
r83316* (bug 26120) CodeReview e-mails (for new comments, follow-up revisions, etc....reedy19:40, 5 March 2011

Status & tagging log