r83216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83215‎ | r83216 | r83217 >
Date:13:57, 4 March 2011
Author:demon
Status:deferred
Tags:
Comment:
(bug 27781) Installer does not warn about 5.1.x. People have been using array_fill_keys() for a little while now, not realizing they broke support for 5.1 in the process. For REL1_17, let's add a compatibility function and a note in INSTALL to say that this will be the last 5.1-supporting release.

Will follow with changes to trunk to bump requirements to 5.2 for the next release. Really everyone should just use 5.3 and be done with it :p

(Also bump minimum Postgres version because I noticed it here)
Modified paths:
  • /branches/REL1_17/phase3/INSTALL (modified) (history)
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/GlobalFunctions.php
@@ -197,6 +197,16 @@
198198 define( 'TC_PCRE', 1 );
199199 define( 'TC_SELF', 1 );
200200 }
 201+
 202+// array_fill_keys() was only added in 5.2, but people use it anyway
 203+// add a back-compat layer for 5.1. See bug 27781
 204+if( !function_exists( 'array_fill_keys' ) ) {
 205+ function array_fill_keys( $keys, $value ) {
 206+ return array_combine( $keys, array_fill( 0, count( $keys ), $value ) );
 207+ }
 208+}
 209+
 210+
201211 /// @endcond
202212
203213
Index: branches/REL1_17/phase3/INSTALL
@@ -6,10 +6,10 @@
77 "in-place", as long as you have the necessary prerequisites available.
88
99 Required software:
10 -* Web server with PHP 5.1.x or higher.
 10+* Web server with PHP 5.1.x or higher (this will be the last release to support 5.1.x)
1111 * A SQL server, the following types are supported
1212 ** MySQL 4.0.14 or higher
13 -** PostgreSQL 8.1 or higher
 13+** PostgreSQL 8.3 or higher
1414 ** SQLite
1515
1616 MediaWiki is developed and tested mainly on Unix/Linux platforms, but should
Index: branches/REL1_17/phase3/RELEASE-NOTES
@@ -496,6 +496,8 @@
497497 * (bug 26716) Provide link to instructions for external editor related preferences.
498498 * (bug 26961) Hide anon edits in watchlist preference now actually works.
499499 * (bug 1379) Installer directory conflicts with some hosts' configuration panel.
 500+* (bug 27781) Installer does not warn about 5.1.x. Added a compatibility function
 501+ for array_key_exists().
500502
501503 === API changes in 1.17 ===
502504 * BREAKING CHANGE: action=patrol now requires POST

Follow-up revisions

RevisionCommit summaryAuthorDate
r83217(bug 27781) Pt 2: Check for minimum PHP version in installer (which is sepera...demon13:58, 4 March 2011

Status & tagging log