r83215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83214‎ | r83215 | r83216 >
Date:13:17, 4 March 2011
Author:demon
Status:ok
Tags:
Comment:
Cleanup r83022: just use IGNORE
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -562,18 +562,16 @@
563563 if ( !$status->isOK() ) {
564564 return $status;
565565 }
566 - if( !$status->value->selectField( 'site_stats', 'ss_row_id' ) ) {
567 - $status->value->insert( 'site_stats', array(
568 - 'ss_row_id' => 1,
569 - 'ss_total_views' => 0,
570 - 'ss_total_edits' => 0,
571 - 'ss_good_articles' => 0,
572 - 'ss_total_pages' => 0,
573 - 'ss_users' => 0,
574 - 'ss_images' => 0 )
575 - );
576 - }
577 -
 566+ $status->value->insert( 'site_stats', array(
 567+ 'ss_row_id' => 1,
 568+ 'ss_total_views' => 0,
 569+ 'ss_total_edits' => 0,
 570+ 'ss_good_articles' => 0,
 571+ 'ss_total_pages' => 0,
 572+ 'ss_users' => 0,
 573+ 'ss_admins' => 0,
 574+ 'ss_images' => 0 ),
 575+ __METHOD__, 'IGNORE' );
578576 return Status::newGood();
579577 }
580578

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83022Skip site stats insertion if theres already a row. Happens if install fails p...demon17:16, 1 March 2011

Status & tagging log