r83209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83208‎ | r83209 | r83210 >
Date:07:37, 4 March 2011
Author:junaidpv
Status:resolved (Comments)
Tags:
Comment:
Narayam: Sinhala more enhancements, Add Oriya transliteration and InScript schemes
Modified paths:
  • /trunk/extensions/Narayam/Narayam.i18n.php (modified) (history)
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)
  • /trunk/extensions/Narayam/ext.narayam.rules.or-inscript.js (added) (history)
  • /trunk/extensions/Narayam/ext.narayam.rules.or.js (added) (history)
  • /trunk/extensions/Narayam/ext.narayam.rules.si-singlish.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/ext.narayam.rules.si-singlish.js
——@@ -6,21 +6,29 @@
77 * License: GPLv3
88 */
99
10 - // Normal rules
 10+// Normal rules
1111 var rules = [
 12+['ඬ්හ්a', '', 'ඳ'], // nndha
 13+['න්න්d', '', 'ඬ්'], // nnd
 14+['න්න්g', '', 'ඟ්'], // nng
 15+['ශ්‍රිi', '', 'ශ්‍රී'], // shrii
 16+['ශ්‍රi', '', 'ශ්‍රි'], // shri
 17+['ශ්r', '', 'ශ්‍ර'], // shr
 18+
1219 ['([\\u0D9A-\\u0DC6])්a', '', '$1'], // <consonant>a
1320 ['([\\u0D9A-\\u0DC6])a', '', '$1ා'], // <consonant>aa
1421 ['([\\u0D9A-\\u0DC6])්A', '', '$1ැ'], // <consonant>A
1522 ['([\\u0D9A-\\u0DC6])ැa', '', '$1ෑ'], // <consonant>Aa
1623 ['([\\u0D9A-\\u0DC6])්i', '', '$1ි'], // <consonant>i
17 -['([\\u0D9A-\\u0DC6])ිe', '', '$1ී'], // <consonant>ie
 24+['([\\u0D9A-\\u0DC6])ි[ei]', '', '$1ී'], // <consonant>ie
1825 ['([\\u0D9A-\\u0DC6])්u', '', '$1ු'], // <consonant>u
1926 ['([\\u0D9A-\\u0DC6])ුu', '', '$1ූ'], // <consonant>u
2027 ['([\\u0D9A-\\u0DC6])්e', '', '$1ෙ'], // <consonant>e
21 -['([\\u0D9A-\\u0DC6])ෙi', '', '$1ේ'], // <consonant>ei
 28+['([\\u0D9A-\\u0DC6])ෙ[ai]', '', '$1ේ'], // <consonant>ei
2229 ['([\\u0D9A-\\u0DC6])්o', '', '$1ො'], // <consonant>o
2330 ['([\\u0D9A-\\u0DC6])ොe', '', '$1ෝ'], // <consonant>oe
2431 ['([\\u0D9A-\\u0DC6])u', '', '$1ෞ'], // <consonant>au
 32+['([\\u0D9A-\\u0DC6])්I', '', '$1ෛ'], // <consonant>I
2533
2634 ['ළුu', '', 'ළුු'], // Luu
2735
——@@ -78,7 +86,7 @@
7987 ['l', '', 'ල්'],
8088 ['D', '', 'ඪ්'],
8189 ['d', '', 'ඩ්'],
82 -['(w|V)', '', 'ව්'],
 90+['(w|v)', '', 'ව්'],
8391 ['s', '', 'ස්'],
8492 ['q', '', 'ඣ්'],
8593 ['h', '', 'හ්'],
——@@ -91,7 +99,7 @@
92100 jQuery.narayam.addScheme( 'si-singlish', {
93101 'namemsg': 'narayam-si-singlish',
94102 'extended_keyboard': false,
95 - 'lookbackLength': 2,
 103+ 'lookbackLength': 5,
96104 'keyBufferLength': 0,
97105 'rules': rules
98106 } );
Index: trunk/extensions/Narayam/Narayam.i18n.php
——@@ -23,6 +23,8 @@
2424 'narayam-kn-inscript' => 'Kannada InScript',
2525 'narayam-ml' => 'Malayalam Transliteration',
2626 'narayam-ml-inscript' => 'Malayalam InScript',
 27+ 'narayam-or' => 'Oriya Transliteration',
 28+ 'narayam-or-inscript' => 'Oriya InScript',
2729 'narayam-sa' => 'Sanskrit Transliteration',
2830 'narayam-sa-inscript' => 'Sanskrit InScript',
2931 'narayam-si-singlish' => 'Sinhala Singlish',
Index: trunk/extensions/Narayam/ext.narayam.rules.or-inscript.js
——@@ -0,0 +1,109 @@
 2+/**
 3+ * InScript regular expression rules table for Oriya script
 4+ * According to CDAC's "Enhanced InScript Keyboard Layout 5.2"
 5+ * @author Junaid P V ([[user:Junaidpv]])
 6+ * @date 2011-02-28
 7+ * License: GPLv3
 8+ */
 9+
 10+var rules = [
 11+['X', '', '\u0B01'],
 12+['x', '', '\u0B02'],
 13+['_', '', '\u0B03'],
 14+['D', '', '\u0B05'],
 15+['E', '', '\u0B06'],
 16+['F', '', '\u0B07'],
 17+['R', '', '\u0B08'],
 18+['G', '', '\u0B09'],
 19+['T', '', '\u0B0A'],
 20+['\\+', '', '\u0B0B'],
 21+['S', '', '\u0B0F'],
 22+['W', '', '\u0B10'],
 23+['A', '', '\u0B13'],
 24+['Q', '', '\u0B14'],
 25+['k', '', '\u0B15'],
 26+['K', '', '\u0B16'],
 27+['i', '', '\u0B17'],
 28+['I', '', '\u0B18'],
 29+['U', '', '\u0B19'],
 30+[';', '', '\u0B1A'],
 31+['\\:', '', '\u0B1B'],
 32+['p', '', '\u0B1C'],
 33+['P', '', '\u0B1D'],
 34+['\\}', '', '\u0B1E'],
 35+['`', '', '\u0B1F'],
 36+['~', '', '\u0B20'],
 37+['\\[', '', '\u0B21'],
 38+['\\{', '', '\u0B22'],
 39+['C', '', '\u0B23'],
 40+['l', '', '\u0B24'],
 41+['L', '', '\u0B25'],
 42+['o', '', '\u0B26'],
 43+['O', '', '\u0B27'],
 44+['v', '', '\u0B28'],
 45+['h', '', '\u0B2A'],
 46+['H', '', '\u0B2B'],
 47+['y', '', '\u0B2C'],
 48+['Y', '', '\u0B2D'],
 49+['c', '', '\u0B2E'],
 50+['\\?', '', '\u0B2F'],
 51+['j', '', '\u0B30'],
 52+['n', '', '\u0B32'],
 53+['N', '', '\u0B33'],
 54+['M', '', '\u0B36'],
 55+['\\<', '', '\u0B37'],
 56+['m', '', '\u0B38'],
 57+['u', '', '\u0B39'],
 58+['\\]', '', '\u0B3C'],
 59+['e', '', '\u0B3E'],
 60+['f', '', '\u0B3F'],
 61+['r', '', '\u0B40'],
 62+['g', '', '\u0B41'],
 63+['t', '', '\u0B42'],
 64+['\\=', '', '\u0B43'],
 65+['s', '', '\u0B47'],
 66+['w', '', '\u0B48'],
 67+['a', '', '\u0B4B'],
 68+['q', '', '\u0B4C'],
 69+['d', '', '\u0B4D'],
 70+['/', '', '\u0B5F'],
 71+['\\>', '', '\u0B64'],
 72+['0', '', '\u0B66'],
 73+['1', '', '\u0B67'],
 74+['2', '', '\u0B68'],
 75+['3', '', '\u0B69'],
 76+['4', '', '\u0B6A'],
 77+['5', '', '\u0B6B'],
 78+['6', '', '\u0B6C'],
 79+['7', '', '\u0B6D'],
 80+['8', '', '\u0B6E'],
 81+['9', '', '\u0B6F'],
 82+['b', '', '\u0B71'],
 83+['\\(', '', '\u200D'],
 84+['\\)', '', '\u200C']
 85+];
 86+
 87+var rules_x = [
 88+['F', '', '\u0B0C'],
 89+['b', '', '\u0B35'],
 90+['\\>', '', '\u0B3D'],
 91+['\\=', '', '\u0B44'],
 92+['\\[', '', '\u0B5C'],
 93+['\\{', '', '\u0B5D'],
 94+['\\+', '', '\u0B60'],
 95+['R', '', '\u0B61'],
 96+['f', '', '\u0B62'],
 97+['r', '', '\u0B63'],
 98+['\\.', '', '\u0B65'],
 99+['x', '', '\u0B70'],
 100+['\\$', '', '\u20B9']
 101+];
 102+
 103+jQuery.narayam.addScheme( 'or-inscript', {
 104+ 'namemsg': 'narayam-or-inscript',
 105+ 'extended_keyboard': true,
 106+ 'lookbackLength': 0,
 107+ 'keyBufferLength': 0,
 108+ 'rules': rules,
 109+ 'rules_x': rules_x
 110+} );
Property changes on: trunk/extensions/Narayam/ext.narayam.rules.or-inscript.js
___________________________________________________________________
Added: svn:eol-style
1111 + native
Index: trunk/extensions/Narayam/ext.narayam.rules.or.js
——@@ -0,0 +1,125 @@
 2+/**
 3+ * Trasliteration regular expression rules table for Oriya
 4+ * @author Junaid P V ([[user:Junaidpv]])
 5+ * @date 2010-11-13
 6+ * @credit With help from Subhashish Panigrahi
 7+ * License: GPLv3, CC-BY-SA 3.0
 8+ */
 9+// Normal rules
 10+var rules = [
 11+['\\\\([A-Za-z\\>_~\\.0-9])', '\\\\','$2'],
 12+
 13+['ଞ୍ଜ୍h', '', 'ଞ୍ଝ୍'], // njh
 14+['ଙ୍ଗ୍h', '', 'ଙ୍ଘ୍'], // ngh
 15+
 16+['([କ-ହ])୍a', '','$2'],
 17+['([କ-ହ])(a|୍A)', '','$2ା'],
 18+['([କ-ହ])୍i', '','$2\u0b3f'],
 19+['([କ-ହ])(୍I|\u0b3fe)', '','$2ୀ'],
 20+['([କ-ହ])୍u', '','$2\u0b41'],
 21+['([କ-ହ])(୍U|\u0b41u)', '','$2\u0b42'],
 22+['([କ-ହ])୍R', '','$2\u0b43'],
 23+['([କ-ହ])\u0b43R', '','$2\u0b44'],
 24+['([କ-ହ])୍ଳ୍l', '','$2ୢ'],
 25+['([କ-ହ])ୢl', '','$2ୣ'],
 26+['([କ-ହ])୍e', '','$2େ'],
 27+['([କ-ହ])i', '','$2ୈ'],
 28+['([କ-ହ])୍o', '','$2ୋ'],
 29+['([କ-ହ])ୋu', '','$2ୌ'],
 30+['([କ-ହ])୍E', '','$2\u0B48'],
 31+
 32+['ଅa', '','ଆ'],
 33+['(ଅi|ଏe)', '','ଐ'],
 34+['(ଅu|ଓo|ଓO)', '','ଔ'],
 35+['ଋR', '','ୠ'],
 36+['ଳ୍l', '','ଌ'],
 37+['ଌl', '','ୡ'],
 38+
 39+['କ୍h', '','ଖ୍'],
 40+['ଗ୍h', '','ଘ୍'],
 41+['ନ୍g', '', 'ଙ୍ଗ୍'], // ng
 42+['ଚ୍h', '','ଛ୍'],
 43+['ଜ୍h', '','ଝ୍'],
 44+['ନ୍j', '', 'ଞ୍ଜ୍'], // nj
 45+['ଟ୍h', '','ଠ୍'],
 46+['ଡ୍h', '','ଢ୍'],
 47+['ତ୍h', '','ଥ୍'],
 48+['ଦ୍h', '','ଧ୍'],
 49+['ପ୍h', '','ଫ୍'],
 50+['ବ୍h', '','ଭ୍'],
 51+['ସ୍h', '','ଷ୍'],
 52+['।Z', '', '॥'],
 53+
 54+['a', '','ଅ'],
 55+['b', '','ବ୍'],
 56+['c','','ଚ୍'],
 57+['d', '','ଦ୍'],
 58+['e', '','ଏ'],
 59+['f', '','ଫ୍'],
 60+['g', '','ଗ୍'],
 61+['h', '','ହ୍'],
 62+['i', '','ଇ'],
 63+['j', '','ଜ୍'],
 64+['k', '','କ୍'],
 65+['l', '','ଲ୍'],
 66+['m', '','ମ୍'],
 67+['n', '','ନ୍'],
 68+['o', '','ଓ'],
 69+['p', '','ପ୍'],
 70+['q', '', 'କ୍ଷ୍'],
 71+['r', '','ର୍'],
 72+['s', '','ସ୍'],
 73+['t', '','ତ୍'],
 74+['u', '','ଉ'],
 75+['v', '', 'ୱ୍'],
 76+['w', '','ଵ୍'],
 77+['x', '','ଂ'],
 78+['y', '','ୟ୍'],
 79+['z', '','\u0B3C'],
 80+['A', '','ଆ'],
 81+['B', '','ବ୍'],
 82+['C', '','ଛ୍'],
 83+['D', '','ଡ୍'],
 84+['E', '','ଐ'],
 85+['F', '','ଫ୍'],
 86+['G', '','ଗ୍'],
 87+['H', '','ଃ'],
 88+['I', '','ଈ'],
 89+['J', '','ଝ୍'],
 90+['K', '','କ୍'],
 91+['L', '','ଳ୍'],
 92+['M', '','ମ୍'],
 93+['N', '','ଣ୍'],
 94+['O', '', 'ଔ'],
 95+['P', '','ଫ୍'],
 96+['Q', '', 'ଜ୍ଞ୍'],
 97+['R', '','ଋ'],
 98+['S', '','ଶ୍'],
 99+['T', '','ଟ୍'],
 100+['U', '','ଊ'],
 101+['V', '', 'ଵ୍'],
 102+['W', '','ଵ୍ଵ୍'],
 103+['X', '', 'ଁ'],
 104+['Y', '','ଯ୍'],
 105+['Z', '', '।'],
 106+['\\~', '','୍'],
 107+['//', '','ଽ'],
 108+['0', '','୦'],
 109+['1', '','୧'],
 110+['2', '','୨'],
 111+['3', '','୩'],
 112+['4', '','୪'],
 113+['5', '','୫'],
 114+['6', '','୬'],
 115+['7', '','୭'],
 116+['8', '','୮'],
 117+['9', '','୯']
 118+];
 119+
 120+jQuery.narayam.addScheme( 'or', {
 121+ 'namemsg': 'narayam-or',
 122+ 'extended_keyboard': true,
 123+ 'lookbackLength': 0,
 124+ 'keyBufferLength': 0,
 125+ 'rules': rules
 126+} );
Property changes on: trunk/extensions/Narayam/ext.narayam.rules.or.js
___________________________________________________________________
Added: svn:eol-style
1127 + native
Index: trunk/extensions/Narayam/Narayam.php
——@@ -61,6 +61,10 @@
6262 'ml' => 'ext.narayam.rules.ml',
6363 'ml-inscript' => 'ext.narayam.rules.ml-inscript',
6464 ),
 65+ 'or' => array(
 66+ 'or' => 'ext.narayam.rules.or',
 67+ 'or-inscript' => 'ext.narayam.rules.or-inscript',
 68+ ),
6569 'sa' => array(
6670 'sa' => 'ext.narayam.rules.sa',
6771 'sa-inscript' => 'ext.narayam.rules.sa-inscript',
——@@ -161,6 +165,16 @@
162166 'messages' => array( 'narayam-ml' ),
163167 'dependencies' => 'ext.narayam.core',
164168 );
 169+$wgResourceModules['ext.narayam.rules.or'] = $narayamTpl + array(
 170+ 'scripts' => 'ext.narayam.rules.or.js',
 171+ 'messages' => array( 'narayam-or' ),
 172+ 'dependencies' => 'ext.narayam.core',
 173+);
 174+$wgResourceModules['ext.narayam.rules.or-inscript'] = $narayamTpl + array(
 175+ 'scripts' => 'ext.narayam.rules.or-inscript.js',
 176+ 'messages' => array( 'narayam-or-inscript' ),
 177+ 'dependencies' => 'ext.narayam.core',
 178+);
165179 $wgResourceModules['ext.narayam.rules.sa'] = $narayamTpl + array(
166180 'scripts' => 'ext.narayam.rules.sa.js',
167181 'messages' => array( 'narayam-sa' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r83585Naryam: Add escaping for English characters on Sinhala Singlish. Correct erro...junaidpv12:55, 9 March 2011

Comments

#Comment by Catrope (talk | contribs)   18:33, 7 March 2011 
+['\\\\([A-Za-z\\>_~\\.0-9])', '\\\\','$2'],

Shouldn't this (and all other instances in that file) use $1 instead of $2? 

+	'lookbackLength': 0,
+	'keyBufferLength': 0,

This isn't right.

#Comment by Junaidpv (talk | contribs)   13:13, 8 March 2011

Yes, I committed wrong, both occurred by copy pasting. I will correct it now.

Status & tagging log