r83063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83062‎ | r83063 | r83064 >
Date:02:53, 2 March 2011
Author:yaron
Status:deferred (Comments)
Tags:
Comment:
Reverted r82242 - undid special handling for displaying the month of May, which is, after all, Eurocentric. :)
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
——@@ -317,7 +317,7 @@
318318 wfMsgForContent( 'february' ),
319319 wfMsgForContent( 'march' ),
320320 wfMsgForContent( 'april' ),
321 - wfMsgForContent( 'may_long' ),
 321+ wfMsgForContent( 'may' ),
322322 wfMsgForContent( 'june' ),
323323 wfMsgForContent( 'july' ),
324324 wfMsgForContent( 'august' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r83089Reverted r83063, restored r82242 - using 'may_long' is in fact better than 'may'yaron14:52, 2 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82242Minor tweakjeroendedauw13:29, 16 February 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:18, 2 March 2011

Whaat? What do you mean by Eurocentric? Let me give you an example: 

'september'     => 'September',
'october'       => 'October',
'dec'           => 'Dec',

How does that make any sense? I switched may_long to another month for clarity.

#Comment by Yaron Koren (talk | contribs)   14:54, 2 March 2011

Oh, oops - Jeroen couldn't remember why he had made the change, so I guessed incorrectly that it was for the exact opposite reason. Thanks for the explanation - I just reverted my revert.

Status & tagging log