r83013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83012‎ | r83013 | r83014 >
Date:12:52, 1 March 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Revert r81741 (temporary 1.17 transition workaround to avoid parser cache clear). Was broken, see CR.
Modified paths:
  • /branches/wmf/1.17wmf1/includes/parser/ParserCache.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/parser/ParserCache.php
——@@ -136,11 +136,6 @@
137137
138138 $value = $this->mMemc->get( $parserOutputKey );
139139 if ( !$value ) {
140 - wfDebug( "New format parser cache miss.\n" );
141 - $parserOutputKey = $this->getParserOutputKey( $article, ParserOptions::legacyOptions() );
142 - $value = $this->mMemc->get( $parserOutputKey );
143 - }
144 - if ( !$value ) {
145140 wfDebug( "Parser cache miss.\n" );
146141 wfIncrStats( "pcache_miss_absent" );
147142 wfProfileOut( __METHOD__ );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81741Provisional workaround for parser cache interaction with r70783...brion15:02, 8 February 2011

Comments

#Comment by Platonides (talk | contribs)   15:14, 1 March 2011

Now the "TODO: Fail here $wgParserCacheExpireTime after deployment unless $useOutdated" could also be resolved, then.

Status & tagging log